cal/claude-memory
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

store: PR review: paper-dynasty-database#48 (APPROVED)

Browse Source
This commit is contained in:
Cal Corum 2026-03-04 22:18:52 -06:00
parent f18b8decdc
commit f6730a4b6f
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
graph/workflows/pr-review-paper-dynasty-database48-approved-91e3a8.md Normal file
View File

@ -0,0 +1,12 @@
---
id: 91e3a804-1d80-4a19-a968-fd47f5ed5aad
type: workflow
title: "PR review: paper-dynasty-database#48 (APPROVED)"
tags: [pr-reviewer, paper-dynasty-database, automation]
importance: 0.5
confidence: 0.8
created: "2026-03-05T04:18:52.073987+00:00"
updated: "2026-03-05T04:18:52.073987+00:00"
---
Reviewed paper-dynasty-database PR #48 — fix: replace broad except Exception blocks with DoesNotExist (#15). Verdict: APPROVED. Summary: Clean, focused fix applied consistently across 19 files. Narrowing from `except Exception` to `except DoesNotExist` is technically correct — `peewee.DoesNotExist` is exactly what `Model.get_by_id()` raises on miss, and it is the base class for all model-specific DoesNotExist exceptions. Import path via `db_engine` (which does `from peewee import *`) is valid. Real DB errors now propagate as 500s instead of being masked as 404s. No security or style issues. Note: Gitea blocked a formal APPROVED review state (self-review restriction); posted as COMMENT with APPROVED verdict.. Cost: $0.40518499999999996