cal/claude-memory
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

store: PR review: paper-dynasty-database#42 — remove duplicate ranking_max filter

Browse Source
This commit is contained in:
Cal Corum 2026-03-03 16:17:25 -06:00
parent ad037d5dcf
commit 3a59e527f2
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
graph/workflows/pr-review-paper-dynasty-database42-remove-duplicate-ranking-bf1e80.md Normal file
View File

@ -0,0 +1,24 @@
---
id: bf1e80d7-cec9-4853-85a4-260f2fe3e0eb
type: workflow
title: "PR review: paper-dynasty-database#42 — remove duplicate ranking_max filter"
tags: [pr-reviewer, paper-dynasty-database, fastapi, peewee, python, duplicate-code]
importance: 0.4
confidence: 0.8
created: "2026-03-03T22:17:25.193256+00:00"
updated: "2026-03-03T22:17:25.193256+00:00"
---
## PR #42: fix: remove duplicate ranking_max filter in get_teams
**Verdict**: APPROVED (posted as COMMENT — Gitea blocks self-approval)
**Files reviewed**: `app/routers_v2/teams.py`
**Change**: Removed 3 lines — a duplicate `if ranking_max is not None: all_teams = all_teams.where(Team.ranking <= ranking_max)` block at old lines 141–143, identical to the block at lines 138–140.
**Analysis**: The duplicate was a no-op copy-paste. Peewee would have generated `WHERE ranking <= $1 AND ranking <= $1` — valid but redundant SQL. Removal has zero functional impact.
**Issues found**: None. Correctness, security, and conventions all clear.
**Note**: PR from `ai/paper-dynasty-database#21` branch (agent-created). Gitea API returns "approve your own pull is not allowed" when authenticated user is the PR author — used COMMENT state as fallback.