diff --git a/graph/workflows/pr-review-paper-dynasty-database42-remove-duplicate-ranking-bf1e80.md b/graph/workflows/pr-review-paper-dynasty-database42-remove-duplicate-ranking-bf1e80.md new file mode 100644 index 00000000000..0d77e2852cd --- /dev/null +++ b/graph/workflows/pr-review-paper-dynasty-database42-remove-duplicate-ranking-bf1e80.md @@ -0,0 +1,24 @@ +--- +id: bf1e80d7-cec9-4853-85a4-260f2fe3e0eb +type: workflow +title: "PR review: paper-dynasty-database#42 — remove duplicate ranking_max filter" +tags: [pr-reviewer, paper-dynasty-database, fastapi, peewee, python, duplicate-code] +importance: 0.4 +confidence: 0.8 +created: "2026-03-03T22:17:25.193256+00:00" +updated: "2026-03-03T22:17:25.193256+00:00" +--- + +## PR #42: fix: remove duplicate ranking_max filter in get_teams + +**Verdict**: APPROVED (posted as COMMENT — Gitea blocks self-approval) + +**Files reviewed**: `app/routers_v2/teams.py` + +**Change**: Removed 3 lines — a duplicate `if ranking_max is not None: all_teams = all_teams.where(Team.ranking <= ranking_max)` block at old lines 141–143, identical to the block at lines 138–140. + +**Analysis**: The duplicate was a no-op copy-paste. Peewee would have generated `WHERE ranking <= $1 AND ranking <= $1` — valid but redundant SQL. Removal has zero functional impact. + +**Issues found**: None. Correctness, security, and conventions all clear. + +**Note**: PR from `ai/paper-dynasty-database#21` branch (agent-created). Gitea API returns "approve your own pull is not allowed" when authenticated user is the PR author — used COMMENT state as fallback.