cal/claude-memory
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

store: PR review: paper-dynasty-database#35 — remove dead roster CSV fields

Browse Source
This commit is contained in:
Cal Corum 2026-03-03 12:35:29 -06:00
parent bd696fae46
commit 24cc3c87b9
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
graph/workflows/pr-review-paper-dynasty-database35-remove-dead-roster-csv-fi-b1eb16.md Normal file
View File

@ -0,0 +1,22 @@
---
id: b1eb1655-e006-447d-a0cf-bba7a914b331
type: workflow
title: "PR review: paper-dynasty-database#35 — remove dead roster CSV fields"
tags: [pr-reviewer, paper-dynasty, paper-dynasty-database, fastapi, python, csv, dead-code, card-model]
importance: 0.4
confidence: 0.8
created: "2026-03-03T18:35:29.790614+00:00"
updated: "2026-03-03T18:35:29.790614+00:00"
---
## PR Review: paper-dynasty-database#35
**Verdict**: APPROVED (posted as COMMENT — Gitea blocks self-approval)
**Fix**: Removed non-existent `roster1.name`, `roster2.name`, `roster3.name` attribute accesses from `v1_cards_get_one` CSV branch in `app/routers_v2/cards.py` (lines 144–146).
**Confirmed**: `Card` model in `db_engine.py` (lines 472–491) has only `player`, `team`, `pack`, `value` fields. The removed attributes would have raised `AttributeError` on every `?csv=true` request.
**Pre-existing issue noted (out of scope)**: `v1_cards_patch` still accepts `roster1_id`, `roster2_id`, `roster3_id` params and assigns them to `this_card` (lines 332–337), but Peewee silently drops unknown attributes on save — no runtime error, just dead API surface.
**Note**: Gitea does not allow APPROVED reviews on your own PRs. Posted as COMMENT instead.