From 24cc3c87b9a00f11af1b9a674dba4b81ac88da28 Mon Sep 17 00:00:00 2001 From: Cal Corum Date: Tue, 3 Mar 2026 12:35:29 -0600 Subject: [PATCH] =?UTF-8?q?store:=20PR=20review:=20paper-dynasty-database#?= =?UTF-8?q?35=20=E2=80=94=20remove=20dead=20roster=20CSV=20fields?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- ...base35-remove-dead-roster-csv-fi-b1eb16.md | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 graph/workflows/pr-review-paper-dynasty-database35-remove-dead-roster-csv-fi-b1eb16.md diff --git a/graph/workflows/pr-review-paper-dynasty-database35-remove-dead-roster-csv-fi-b1eb16.md b/graph/workflows/pr-review-paper-dynasty-database35-remove-dead-roster-csv-fi-b1eb16.md new file mode 100644 index 00000000000..55727dab635 --- /dev/null +++ b/graph/workflows/pr-review-paper-dynasty-database35-remove-dead-roster-csv-fi-b1eb16.md @@ -0,0 +1,22 @@ +--- +id: b1eb1655-e006-447d-a0cf-bba7a914b331 +type: workflow +title: "PR review: paper-dynasty-database#35 — remove dead roster CSV fields" +tags: [pr-reviewer, paper-dynasty, paper-dynasty-database, fastapi, python, csv, dead-code, card-model] +importance: 0.4 +confidence: 0.8 +created: "2026-03-03T18:35:29.790614+00:00" +updated: "2026-03-03T18:35:29.790614+00:00" +--- + +## PR Review: paper-dynasty-database#35 + +**Verdict**: APPROVED (posted as COMMENT — Gitea blocks self-approval) + +**Fix**: Removed non-existent `roster1.name`, `roster2.name`, `roster3.name` attribute accesses from `v1_cards_get_one` CSV branch in `app/routers_v2/cards.py` (lines 144–146). + +**Confirmed**: `Card` model in `db_engine.py` (lines 472–491) has only `player`, `team`, `pack`, `value` fields. The removed attributes would have raised `AttributeError` on every `?csv=true` request. + +**Pre-existing issue noted (out of scope)**: `v1_cards_patch` still accepts `roster1_id`, `roster2_id`, `roster3_id` params and assigns them to `this_card` (lines 332–337), but Peewee silently drops unknown attributes on save — no runtime error, just dead API surface. + +**Note**: Gitea does not allow APPROVED reviews on your own PRs. Posted as COMMENT instead.