Strat Gameplay WebApp - Web interface for Strat-o-Matic gameplay
Go to file
Cal Corum efd38d2580 CLAUDE: Phase 3F - Substitution System Testing Complete
Completed final 20% of substitution system with comprehensive test coverage.
All 640 unit tests passing (100%). Phase 3 now 100% complete.

## Unit Tests (31 tests) - NEW

tests/unit/core/test_substitution_rules.py:
- TestPinchHitterValidation: 6 tests
  * Success case
  * NOT_CURRENT_BATTER validation
  * PLAYER_ALREADY_OUT validation
  * NOT_IN_ROSTER validation
  * ALREADY_ACTIVE validation
  * Bench player edge case

- TestDefensiveReplacementValidation: 9 tests
  * Success case
  * Position change allowed
  * PLAYER_ALREADY_OUT validation
  * NOT_IN_ROSTER validation
  * ALREADY_ACTIVE validation
  * INVALID_POSITION validation
  * All valid positions (P, C, 1B-3B, SS, LF-RF, DH)
  * Mid-inning warning logged
  * allow_mid_inning flag works

- TestPitchingChangeValidation: 7 tests
  * Success case (after min batters)
  * PLAYER_ALREADY_OUT validation
  * NOT_A_PITCHER validation
  * MIN_BATTERS_NOT_MET validation
  * force_change bypasses min batters
  * NOT_IN_ROSTER validation
  * ALREADY_ACTIVE validation

- TestDoubleSwitchValidation: 6 tests
  * Success case with batting order swap
  * First substitution invalid
  * Second substitution invalid
  * INVALID_BATTING_ORDER validation
  * DUPLICATE_BATTING_ORDER validation
  * All valid batting order combinations (1-9)

- TestValidationResultDataclass: 3 tests
  * Valid result creation
  * Invalid result with error
  * Result with message only

## Integration Tests (10 tests) - NEW

tests/integration/test_substitution_manager.py:
- TestPinchHitIntegration: 2 tests
  * Full flow: validation → DB → state sync
  * Validation failure (ALREADY_ACTIVE)

- TestDefensiveReplacementIntegration: 2 tests
  * Full flow with DB/state verification
  * Position change (SS → 2B)

- TestPitchingChangeIntegration: 3 tests
  * Full flow with current_pitcher update
  * MIN_BATTERS_NOT_MET validation
  * force_change emergency bypass

- TestSubstitutionStateSync: 3 tests
  * Multiple substitutions stay synced
  * Batting order preserved after substitution
  * State cache matches database

Fixtures:
- game_with_lineups: Creates game with 9 active + 3 bench players
- Proper async session management
- Database cleanup handled

## Bug Fixes

app/core/substitution_rules.py:
- Fixed to use new GameState structure
- Changed: state.current_batter_lineup_id → state.current_batter.lineup_id
- Aligns with Phase 3E GameState refactoring

## Test Results

Unit Tests:
- 640/640 passing (100%)
- 31 new substitution tests
- All edge cases covered
- Execution: 1.02s

Integration Tests:
- 10 tests implemented
- Full DB + state sync verification
- Note: Run individually due to known asyncpg connection issues

## Documentation Updates

.claude/implementation/NEXT_SESSION.md:
- Updated Phase 3 progress to 100% complete
- Marked Task 2 (unit tests) completed
- Marked Task 3 (integration tests) completed
- Updated success criteria with completion notes
- Documented test counts and coverage

## Phase 3 Status: 100% COMPLETE 

- Phase 3A-D (X-Check Core): 100%
- Phase 3E-Prep (GameState Refactor): 100%
- Phase 3E-Main (Position Ratings): 100%
- Phase 3E-Final (Redis/WebSocket): 100%
- Phase 3E Testing (Terminal Client): 100%
- Phase 3F (Substitutions): 100%

All core gameplay features implemented and fully tested.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-04 22:34:17 -06:00
.claude CLAUDE: Phase 3F - Substitution System Testing Complete 2025-11-04 22:34:17 -06:00
backend CLAUDE: Phase 3F - Substitution System Testing Complete 2025-11-04 22:34:17 -06:00
frontend-pd CLAUDE: Complete Phase 1 - Frontend Infrastructure Setup 2025-10-22 00:24:00 -05:00
frontend-sba SBa name update 2025-10-22 11:22:15 -05:00
.dockerignore CLAUDE: Initial project setup - documentation and infrastructure 2025-10-21 16:21:13 -05:00
.env.example CLAUDE: Initial project setup - documentation and infrastructure 2025-10-21 16:21:13 -05:00
.gitattributes Initial commit 2025-10-21 15:15:33 -05:00
.gitignore CLAUDE: Initial project setup - documentation and infrastructure 2025-10-21 16:21:13 -05:00
CLAUDE.md CLAUDE: Initial project setup - documentation and infrastructure 2025-10-21 16:21:13 -05:00
docker-compose.yml SBa name update 2025-10-22 11:22:15 -05:00
prd-web-scorecard-1.1.md CLAUDE: Initial project setup - documentation and infrastructure 2025-10-21 16:21:13 -05:00
QUICKSTART.md CLAUDE: Update project documentation for UV migration 2025-11-04 09:25:44 -06:00
README.md CLAUDE: Update project documentation for UV migration 2025-11-04 09:25:44 -06:00

Paper Dynasty Real-Time Game Engine

Web-based real-time multiplayer baseball simulation platform replacing the legacy Google Sheets system.

Project Structure

strat-gameplay-webapp/
├── backend/              # FastAPI game engine
├── frontend-sba/         # SBA League Nuxt frontend
├── frontend-pd/          # PD League Nuxt frontend
├── .claude/              # Claude AI implementation guides
├── docker-compose.yml    # Full stack orchestration
└── README.md            # This file

Two Development Workflows

Best for: Fast hot-reload, quick iteration, debugging

Services:

  • Backend runs locally (Python hot-reload)
  • Frontends run locally (Nuxt hot-reload)
  • Redis in Docker (lightweight)
  • PostgreSQL on your existing server

Setup:

  1. Environment Setup

    # Copy environment template
    cp .env.example .env
    # Edit .env with your database credentials and API keys
    
  2. Start Redis (in one terminal)

    cd backend
    docker-compose up
    
  3. Start Backend (in another terminal)

    cd backend
    uv run python -m app.main
    # Or manually activate: source .venv/bin/activate && python -m app.main
    

    Backend will be available at http://localhost:8000

  4. Start SBA Frontend (in another terminal)

    cd frontend-sba
    npm run dev
    

    SBA frontend will be available at http://localhost:3000

  5. Start PD Frontend (in another terminal)

    cd frontend-pd
    npm run dev
    

    PD frontend will be available at http://localhost:3001

Advantages:

  • Instant hot-reload on code changes
  • 🐛 Easy debugging (native debuggers work)
  • 💨 Fast startup times
  • 🔧 Simple to restart individual services

Option 2: Full Docker Orchestration

Best for: Integration testing, demos, production-like environment

Services:

  • Everything runs in containers
  • Consistent environment
  • One command to start everything

Setup:

  1. Environment Setup

    # Copy environment template
    cp .env.example .env
    # Edit .env with your database credentials and API keys
    
  2. Start Everything

    # From project root
    docker-compose up
    

    Or run in background:

    docker-compose up -d
    
  3. View Logs

    # All services
    docker-compose logs -f
    
    # Specific service
    docker-compose logs -f backend
    docker-compose logs -f frontend-sba
    
  4. Stop Everything

    docker-compose down
    

Advantages:

  • 🎯 Production-like environment
  • 🚀 One-command startup
  • 🔄 Easy to share with team
  • CI/CD ready

Development Commands

Backend

cd backend

# Install UV (one-time setup)
curl -LsSf https://astral.sh/uv/install.sh | sh

# Install dependencies
uv sync

# Run server
uv run python -m app.main

# Run tests
uv run pytest tests/ -v

# Code formatting
uv run black app/ tests/

# Linting
uv run flake8 app/ tests/

# Type checking
uv run mypy app/

Frontend

cd frontend-sba  # or frontend-pd

# Install dependencies
npm install

# Run dev server
npm run dev

# Build for production
npm run build

# Preview production build
npm run preview

# Lint
npm run lint

# Type check
npm run type-check

Database Setup

This project uses an existing PostgreSQL server. You need to manually create the database:

-- On your PostgreSQL server
CREATE DATABASE paperdynasty_dev;
CREATE USER paperdynasty WITH PASSWORD 'your-secure-password';
GRANT ALL PRIVILEGES ON DATABASE paperdynasty_dev TO paperdynasty;

Then update DATABASE_URL in .env:

DATABASE_URL=postgresql+asyncpg://paperdynasty:your-password@your-db-server:5432/paperdynasty_dev

Environment Variables

Copy .env.example to .env and configure:

Required

  • DATABASE_URL - PostgreSQL connection string
  • SECRET_KEY - Application secret key (at least 32 characters)
  • DISCORD_CLIENT_ID - Discord OAuth client ID
  • DISCORD_CLIENT_SECRET - Discord OAuth secret
  • SBA_API_URL / SBA_API_KEY - SBA League API credentials
  • PD_API_URL / PD_API_KEY - PD League API credentials

Optional

  • REDIS_URL - Redis connection (auto-configured in Docker)
  • CORS_ORIGINS - Allowed origins (defaults to localhost:3000,3001)

Available Services

When running, the following services are available:

Service URL Description
Backend API http://localhost:8000 FastAPI REST API
Backend Docs http://localhost:8000/docs Interactive API documentation
SBA Frontend http://localhost:3000 SBA League web app
PD Frontend http://localhost:3001 PD League web app
Redis localhost:6379 Cache (not exposed via HTTP)

Health Checks

# Backend health
curl http://localhost:8000/api/health

# Or visit in browser
open http://localhost:8000/api/health

Troubleshooting

Backend won't start

  • Check DATABASE_URL is correct in .env
  • Verify PostgreSQL database exists
  • Ensure Redis is running (docker-compose up in backend/)
  • Check logs for specific errors

Frontend won't connect to backend

  • Verify backend is running at http://localhost:8000
  • Check CORS settings in backend .env
  • Clear browser cache and cookies
  • Check browser console for errors

Docker containers won't start

  • Ensure .env file exists with all required variables
  • Run docker-compose down then docker-compose up again
  • Check docker-compose logs for specific errors
  • Verify no port conflicts (8000, 3000, 3001, 6379)

Database connection fails

  • Verify PostgreSQL server is accessible
  • Check firewall rules allow connection
  • Confirm database and user exist
  • Test connection with psql directly

Documentation

  • Full PRD: See /prd-web-scorecard-1.1.md
  • Implementation Guide: See .claude/implementation/00-index.md
  • Architecture Docs: See .claude/implementation/ directory

Tech Stack

Backend

  • Framework: FastAPI (Python 3.13+)
  • Package Manager: UV (modern Python package management)
  • WebSocket: Socket.io
  • Database: PostgreSQL 14+ with SQLAlchemy
  • Cache: Redis 7
  • Auth: Discord OAuth with JWT

Frontend

  • Framework: Vue 3 + Nuxt 3
  • Language: TypeScript
  • Styling: Tailwind CSS
  • State: Pinia
  • WebSocket: Socket.io-client

Contributing

See .claude/implementation/ for detailed implementation guides and architecture documentation.

License

Proprietary - Paper Dynasty League System