CLAUDE: Implement Week 7 Task 3 - Result chart abstraction and PD auto mode
Core Implementation:
- Added ResultChart abstract base class with get_outcome() method
- Implemented calculate_hit_location() helper for hit distribution
- 45% pull, 35% center, 20% opposite field
- RHB pulls left, LHB pulls right
- Groundballs → infield positions, flyouts → outfield positions
- Added PlayOutcome.requires_hit_location() helper method
- Returns True for groundballs and flyouts only
Manual Mode Support:
- Added ManualResultChart (passthrough for interface completeness)
- Manual mode doesn't use result charts - players submit directly
- Added ManualOutcomeSubmission model for WebSocket submissions
- Validates PlayOutcome enum values
- Validates hit location positions (1B, 2B, SS, 3B, LF, CF, RF, P, C)
PD Auto Mode Implementation:
- Implemented PdAutoResultChart for automated outcome generation
- Coin flip (50/50) to choose batting or pitching card
- Gets rating for correct handedness matchup
- Builds cumulative distribution from rating percentages
- Rolls 1d100 to select outcome
- Calculates hit location using handedness and pull rates
- Maps rating fields to PlayOutcome enum:
- Common: homerun, triple, doubles, singles, walks, strikeouts
- Batting-specific: lineouts, popouts, flyout variants, groundout variants
- Pitching-specific: uncapped singles/doubles, flyouts by location
- Proper error handling when card data missing
Testing:
- Created 21 comprehensive unit tests (all passing)
- Helper function tests (calculate_hit_location)
- PlayOutcome helper tests (requires_hit_location)
- ManualResultChart tests (NotImplementedError)
- PdAutoResultChart tests:
- Coin flip distribution (~50/50)
- Handedness matchup selection
- Cumulative distribution building
- Outcome selection from probabilities
- Hit location calculation
- Error handling for missing cards
- Statistical distribution verification (1000 trials)
- ManualOutcomeSubmission validation tests
- Valid/invalid outcomes
- Valid/invalid hit locations
- Optional location handling
Deferred to Future Tasks:
- PlayResolver integration (Phase 6 - Week 7 Task 3B)
- Terminal client manual outcome command (Phase 8)
- WebSocket handlers for manual submissions (Week 7 Task 6)
- Runner advancement logic using hit locations (Week 7 Task 4)
Files Modified:
- app/config/result_charts.py: Added base class, auto mode, and helpers
- app/models/game_models.py: Added ManualOutcomeSubmission model
- tests/unit/config/test_result_charts.py: 21 comprehensive tests
All tests passing, no regressions.
9245b4e008