strat-gameplay-webapp/backend/app/core
Cal Corum e6bd66ee39 CLAUDE: Fix game recovery for new GameState structure
Fixed state_manager._rebuild_state_from_data to provide required
current_batter field when recovering games from database. The GameState
model now requires current_batter as a LineupPlayerState object, but
recovery was not populating this field, causing validation errors.

Changes:
- state_manager.py: Create placeholder current_batter during recovery
  - Build LineupPlayerState from first active batter (batting_order=1)
  - Fallback to first available lineup if no #1 batter found
  - Raise error if no lineups exist (invalid game state)
  - _prepare_next_play() will correct the batter after recovery
  - Moved get_lineup_player helper to top of method (removed duplicate)

- tests/unit/core/test_state_manager.py: Update test to use new structure
  - test_update_state_nonexistent_raises_error: Create LineupPlayerState
    instead of using old current_batter_lineup_id field

All 26 state_manager unit tests passing. Game recovery now works
correctly in terminal client - fixes "current_batter Field required"
validation error when running status command on recovered games.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-04 15:26:00 -06:00
..
__init__.py CLAUDE: Complete Week 4 - State Management & Persistence 2025-10-22 12:01:03 -05:00
ai_opponent.py CLAUDE: Implement Week 7 Task 1 - Strategic Decision Integration 2025-10-29 21:38:11 -05:00
cache.py CLAUDE: Implement Phase 3A - X-Check data models and enums 2025-11-01 15:32:09 -05:00
CLAUDE.md CLAUDE: Update REPL for new GameState and standardize UV commands 2025-11-04 09:59:13 -06:00
dice.py CLAUDE: Complete Week 6 - granular PlayOutcome integration and metadata support 2025-10-29 20:29:06 -05:00
game_engine.py CLAUDE: Phase 3E-Main - Position Ratings Integration for X-Check Resolution 2025-11-03 21:00:37 -06:00
play_resolver.py CLAUDE: Phase 3E-Main - Position Ratings Integration for X-Check Resolution 2025-11-03 21:00:37 -06:00
roll_types.py CLAUDE: Complete Week 6 - granular PlayOutcome integration and metadata support 2025-10-29 20:29:06 -05:00
runner_advancement.py CLAUDE: Integrate X-Check advancement with full GameState support 2025-11-03 00:21:52 -06:00
state_manager.py CLAUDE: Fix game recovery for new GameState structure 2025-11-04 15:26:00 -06:00
substitution_manager.py CLAUDE: Phase 3 - Substitution System Core Logic 2025-11-03 23:50:33 -06:00
substitution_rules.py CLAUDE: Phase 3 - Substitution System Core Logic 2025-11-03 23:50:33 -06:00
validators.py CLAUDE: Fix defensive decision validation for corners_in/infield_in depths 2025-10-30 10:25:01 -05:00
x_check_advancement_tables.py CLAUDE: Fix critical X-Check bugs and improve dice rolling 2025-11-02 23:09:16 -06:00