strat-gameplay-webapp/backend/tests/unit/core
Cal Corum 5f42576694 CLAUDE: Remove double-dipping on double play probability
Fixed incorrect double play logic that was rolling for probability
twice - once for the chart result and again for execution.

Changes:
- Removed _calculate_double_play_probability() method entirely
- Updated _gb_result_2() to execute DP deterministically
- Updated _gb_result_10() to execute DP deterministically
- Updated _gb_result_13() to execute DP deterministically
- Removed TestDoublePlayProbability test class (5 tests)
- Updated DP tests to reflect deterministic behavior

Logic: Chart already determines outcome via dice roll. When chart
says "Result 2: Double Play", the DP happens (if <2 outs and runner
on 1st exists). No additional probability roll needed.

Tests: 55/55 runner advancement tests passing

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-02 23:58:19 -06:00
..
__init__.py CLAUDE: Complete Week 4 - State Management & Persistence 2025-10-22 12:01:03 -05:00
test_dice.py CLAUDE: Complete Week 6 - granular PlayOutcome integration and metadata support 2025-10-29 20:29:06 -05:00
test_flyball_advancement.py CLAUDE: Integrate flyball advancement with RunnerAdvancement system 2025-10-31 17:04:23 -05:00
test_play_resolver.py CLAUDE: Update tests to match Phase 2 model changes 2025-10-31 16:11:39 -05:00
test_roll_types.py CLAUDE: Complete Week 6 - granular PlayOutcome integration and metadata support 2025-10-29 20:29:06 -05:00
test_runner_advancement.py CLAUDE: Remove double-dipping on double play probability 2025-11-02 23:58:19 -06:00
test_state_manager.py CLAUDE: Update tests to match Phase 2 model changes 2025-10-31 16:11:39 -05:00
test_validators.py CLAUDE: Update tests to match Phase 2 model changes 2025-10-31 16:11:39 -05:00
test_x_check_advancement_tables.py CLAUDE: Fix critical X-Check bugs and improve dice rolling 2025-11-02 23:09:16 -06:00