cal/strat-gameplay-webapp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CLAUDE: Fix squeeze_bunt validation - remove bases loaded restriction

Browse Source 
Removed the incorrect restriction that squeeze bunt cannot be used with bases
loaded. The only requirements for squeeze bunt are:
- Runner on third base
- Not with 2 outs

Updated validator and test to reflect correct rule.

Test results: 739/739 passing (100%)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Cal Corum 2025-11-14 15:09:03 -06:00
parent e165b449f5
commit b0d79ef7ef
2 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
backend/app/core/validators.py
View File

@ -128,12 +128,10 @@ class GameValidator:
if not decision.steal_attempts: if not decision.steal_attempts:
raise ValidationError("Steal action requires steal_attempts to specify which bases to steal") raise ValidationError("Steal action requires steal_attempts to specify which bases to steal")
# Validate squeeze_bunt - requires R3 and bases NOT loaded # Validate squeeze_bunt - requires R3, not with 2 outs
if decision.action == 'squeeze_bunt': if decision.action == 'squeeze_bunt':
if not state.is_runner_on_third(): if not state.is_runner_on_third():
raise ValidationError("Squeeze bunt requires a runner on third base") raise ValidationError("Squeeze bunt requires a runner on third base")
if len(occupied_bases) == 3: # Bases loaded
raise ValidationError("Squeeze bunt cannot be used with bases loaded")
if state.outs >= 2: if state.outs >= 2:
raise ValidationError("Squeeze bunt cannot be used with 2 outs") raise ValidationError("Squeeze bunt cannot be used with 2 outs")

10
backend/tests/unit/core/test_validators.py
View File

@ -732,8 +732,8 @@ class TestOffensiveDecisionValidation:
assert "squeeze bunt requires a runner on third" in str(exc_info.value).lower() assert "squeeze bunt requires a runner on third" in str(exc_info.value).lower()
def test_validate_offensive_decision_action_squeeze_bunt_bases_loaded_fails(self): def test_validate_offensive_decision_action_squeeze_bunt_bases_loaded_succeeds(self):
"""Test squeeze bunt with bases loaded fails""" """Test squeeze bunt with bases loaded succeeds (no restriction on bases loaded)"""
validator = GameValidator() validator = GameValidator()
state = GameState( state = GameState(
game_id=uuid4(), game_id=uuid4(),
@ -748,10 +748,8 @@ class TestOffensiveDecisionValidation:
) )
decision = OffensiveDecision(action="squeeze_bunt") decision = OffensiveDecision(action="squeeze_bunt")
with pytest.raises(ValidationError) as exc_info: # Should not raise - squeeze bunt is allowed with bases loaded
validator.validate_offensive_decision(decision, state) validator.validate_offensive_decision(decision, state)
assert "squeeze bunt cannot be used with bases loaded" in str(exc_info.value).lower()
def test_validate_offensive_decision_action_squeeze_bunt_two_outs_fails(self): def test_validate_offensive_decision_action_squeeze_bunt_two_outs_fails(self):
"""Test squeeze bunt with 2 outs fails""" """Test squeeze bunt with 2 outs fails"""