cal/strat-gameplay-webapp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CLAUDE: Remove hit location requirement from lineout outcomes

Browse Source 
Lineouts are simple outs with no runner advancement logic - the backend
doesn't use hit_location for them (unlike flyouts for sac flies or
groundballs for double plays). Updated OUTCOMES_REQUIRING_HIT_LOCATION
to exclude lineout and added documentation explaining the rationale.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Cal Corum 2025-11-28 12:14:50 -06:00
parent 27b502a7ad
commit af598b3dee
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
frontend-sba/constants/outcomes.ts
View File

@ -69,7 +69,13 @@ export const OUTCOME_CATEGORIES = [
/** /**
* Outcomes that require a hit location to be specified * Outcomes that require a hit location to be specified
* These outcomes involve defensive plays where location matters * These outcomes involve defensive plays where location matters for game logic:
* - Groundballs: determines double play eligibility
* - Flyouts: determines sac fly advancement opportunities
* - Uncapped hits/errors: determines runner advancement
*
* Note: lineout and popout are NOT included because they are simple outs
* with no runner advancement logic - the backend doesn't use hit_location for them
*/ */
export const OUTCOMES_REQUIRING_HIT_LOCATION = [ export const OUTCOMES_REQUIRING_HIT_LOCATION = [
'groundball_a', 'groundball_a',
@ -78,7 +84,6 @@ export const OUTCOMES_REQUIRING_HIT_LOCATION = [
'flyout_a', 'flyout_a',
'flyout_b', 'flyout_b',
'flyout_c', 'flyout_c',
'lineout',
'single_uncapped', 'single_uncapped',
'double_uncapped', 'double_uncapped',
'error', 'error',