cal/strat-gameplay-webapp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CLAUDE: Fix hit location requirements in ManualOutcomeEntry

Browse Source 
Updated outcomesNeedingHitLocation array to only include outcomes that
trigger defensive plays or advancement decisions.

Before (11 outcomes):
- GROUNDOUT, FLYOUT, LINEOUT ✅
- SINGLE_1, SINGLE_2, SINGLE_UNCAPPED ❌ (too broad)
- DOUBLE_2, DOUBLE_3, DOUBLE_UNCAPPED ❌ (too broad)
- TRIPLE ❌ (too broad)
- ERROR ✅

After (6 outcomes):
- GROUNDOUT (all groundouts)
- FLYOUT (all flyouts)
- LINEOUT (all lineouts)
- SINGLE_UNCAPPED (decision tree hits)
- DOUBLE_UNCAPPED (decision tree hits)
- ERROR (defensive plays)

Rationale: Standard hits (SINGLE_1, SINGLE_2, DOUBLE_2, etc.) have
fixed runner advancement and don't need hit location selection.

Session 1 Part 2 - Change #5 complete
Part of cleanup work from demo review

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Cal Corum 2025-11-14 12:56:27 -06:00
parent eab61ad966
commit 2f0f35f951
1 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
frontend-sba/components/Gameplay/ManualOutcomeEntry.vue
View File

@ -149,18 +149,14 @@ const infieldPositions = ['P', 'C', '1B', '2B', '3B', 'SS']
const outfieldPositions = ['LF', 'CF', 'RF']
// Outcomes that require hit location
const outcomesNeedingHitLocation = [ // TODO: Remove unneeded outcomes
'GROUNDOUT',
'FLYOUT',
'LINEOUT',
'SINGLE_1',
'SINGLE_2',
'SINGLE_UNCAPPED',
'DOUBLE_2',
'DOUBLE_3',
'DOUBLE_UNCAPPED',
'TRIPLE',
'ERROR',
// Only outcomes that affect defensive plays require location
const outcomesNeedingHitLocation = [
'GROUNDOUT', // All groundouts
'FLYOUT', // All flyouts
'LINEOUT', // All lineouts
'SINGLE_UNCAPPED', // Decision tree hits
'DOUBLE_UNCAPPED', // Decision tree hits
'ERROR', // Defensive plays
]
// Computed