CLAUDE: Update handoff doc with Part 3 completion
Updated cleanup handoff document with Session 1 Part 3 completion. Changes documented: - Part 3: Defensive alignment removal (11 files modified) - Updated progress: 3/11 changes complete (27%) - Session 1 now 60% complete (Parts 1-3 done, 4-5 remaining) Next steps: - Part 4: Remove offensive approach field (detailed in doc) - Estimated 15-20 minutes - Same pattern as Part 3 Ready for context switch to new session. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Cal Corum
parent
197d91edfb
commit
25b47c157d
@ -2,7 +2,7 @@
|
||||
|
||||
**Date**: 2025-01-14
|
||||
**Current Session**: Cleanup of proposed changes from demo review
|
||||
**Status**: Session 1 Part 1 Complete (2/11 changes done)
|
||||
**Status**: Session 1 Part 3 Complete (3/11 changes done - 27%)
|
||||
|
||||
---
|
||||
|
||||
@ -11,26 +11,26 @@
|
||||
```
|
||||
I'm continuing cleanup work on the Paper Dynasty / SBA web app. We're making changes based on a review of the frontend demo pages.
|
||||
|
||||
Current status: Session 1 Part 1 complete (removed 4 unused config fields). Now need to continue with Session 1 Part 2 and beyond.
|
||||
Current status: Session 1 Part 3 complete (3/11 changes done). Now continuing with Session 1 Part 4.
|
||||
|
||||
Please read these files for full context:
|
||||
- @.claude/PROPOSED_CHANGES_2025-01-14.md (master list of all 11 changes)
|
||||
- @.claude/TODO_CLEANUP_COMPLETE.md (what we just finished)
|
||||
- @backend/app/config/base_config.py (we just modified this)
|
||||
- @backend/tests/unit/config/test_league_configs.py (we just modified this)
|
||||
|
||||
Key decisions from Cal:
|
||||
1. Remove supports_manual_result_selection() - DONE ✅
|
||||
1. Remove supports_manual_result_selection() - ✅ DONE (Part 1)
|
||||
2. Pitching change player ID - Will use league-independent polymorphic Player ID
|
||||
3. Remove defensive alignment & offensive approach - DONE, remove completely
|
||||
3. Remove defensive alignment & offensive approach - ✅ ALIGNMENT DONE (Part 3), approach next
|
||||
4. Offensive workflow refactor - YES, do before Phase F6 (last thing in cleanup)
|
||||
5. Hit location fix - Only needed for: GROUNDOUT, FLYOUT, LINEOUT, SINGLE_UNCAPPED, DOUBLE_UNCAPPED, ERROR
|
||||
5. Hit location fix - ✅ DONE (Part 2): GROUNDOUT, FLYOUT, LINEOUT, SINGLE_UNCAPPED, DOUBLE_UNCAPPED, ERROR
|
||||
|
||||
Completed (Session 1 Parts 1-3):
|
||||
✅ Part 1: Removed strikes_for_out, balls_for_walk, supports_manual_result_selection()
|
||||
✅ Part 2: Fixed hit location requirements (reduced from 11 to 6 outcomes)
|
||||
✅ Part 3: Removed defensive alignment field (11 files modified)
|
||||
|
||||
Current TODO list (in TodoWrite):
|
||||
- [completed] Remove strikes_for_out and balls_for_walk fields
|
||||
- [completed] Remove supports_manual_result_selection() method
|
||||
- [pending] Fix hit location requirements
|
||||
- [pending] Remove defensive alignment from DefensiveDecision model
|
||||
- [completed] Fix hit location requirements in ManualOutcomeEntry.vue
|
||||
- [completed] Remove defensive alignment from DefensiveDecision model
|
||||
- [pending] Remove offensive approach from OffensiveDecision model
|
||||
- [pending] Add infield depth validation (infield_in, corners_in, normal)
|
||||
- [pending] Add outfield depth validation (normal, shallow with walk-off rules)
|
||||
@ -38,18 +38,69 @@ Current TODO list (in TodoWrite):
|
||||
- [pending] Add check jump validation (lead runner only)
|
||||
|
||||
Workflow:
|
||||
- Session 1: Quick wins (Changes #1-5) - IN PROGRESS
|
||||
- Session 1: Quick wins (Changes #1-5) - 60% COMPLETE (Parts 4-5 remaining)
|
||||
- Session 2: Standard changes (Changes #6-7) - NOT STARTED
|
||||
- Session 3: Major refactor (Changes #8-11) - NOT STARTED
|
||||
|
||||
Dev server is running at http://localhost:3005 with demo pages.
|
||||
|
||||
Please continue from Session 1 Part 2: Fix hit location requirements.
|
||||
Please continue from Session 1 Part 4: Remove offensive approach field from OffensiveDecision model.
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
## Files Modified So Far (Session 1 Part 1)
|
||||
## Files Modified So Far
|
||||
|
||||
### Session 1 Part 3: Remove Defensive Alignment (11 files)
|
||||
|
||||
**Backend** (5 files):
|
||||
1. `backend/app/models/game_models.py`
|
||||
- Removed `alignment` field from DefensiveDecision (line 154)
|
||||
- Removed `validate_alignment()` method (lines 159-166)
|
||||
|
||||
2. `backend/terminal_client/display.py`
|
||||
- Removed alignment from defensive decision display (line 191)
|
||||
|
||||
3. `backend/app/core/ai_opponent.py`
|
||||
- Updated log message to remove alignment reference (line 82)
|
||||
|
||||
4. `backend/tests/unit/models/test_game_models.py`
|
||||
- Removed 3 alignment tests (lines 235-245)
|
||||
|
||||
5. `backend/tests/unit/core/test_validators.py`
|
||||
- Removed test_validate_defensive_decision_invalid_alignment (lines 180-191)
|
||||
|
||||
**Frontend** (3 files):
|
||||
1. `frontend-sba/types/game.ts`
|
||||
- Removed `alignment` field from DefensiveDecision interface (line 125)
|
||||
|
||||
2. `frontend-sba/components/Decisions/DefensiveSetup.vue`
|
||||
- Removed "Defensive Alignment" section (lines 19-31)
|
||||
- Removed `alignment` from localSetup (line 154)
|
||||
- Removed `alignmentOptions` array (lines 175-180)
|
||||
- Removed `alignmentDisplay` computed (lines 197-200)
|
||||
- Removed `alignment` from hasChanges (line 226)
|
||||
- Reorganized preview grid (alignment row removed, holding now col-span-2)
|
||||
|
||||
**Git commits**:
|
||||
- Commit 2f0f35f: Hit location fix
|
||||
- Commit 197d91e: Defensive alignment removal
|
||||
|
||||
**Tests**: ✅ All 728 backend unit tests passing
|
||||
|
||||
---
|
||||
|
||||
### Session 1 Part 2: Fix Hit Location Requirements (1 file)
|
||||
|
||||
**Frontend**:
|
||||
1. `frontend-sba/components/Gameplay/ManualOutcomeEntry.vue:152-160`
|
||||
- Reduced `outcomesNeedingHitLocation` from 11 to 6 outcomes
|
||||
- Removed: SINGLE_1, SINGLE_2, DOUBLE_2, DOUBLE_3, TRIPLE
|
||||
- Kept: GROUNDOUT, FLYOUT, LINEOUT, SINGLE_UNCAPPED, DOUBLE_UNCAPPED, ERROR
|
||||
|
||||
---
|
||||
|
||||
### Session 1 Part 1: Remove Unused Config Fields (2 files)
|
||||
|
||||
### backend/app/config/base_config.py
|
||||
**Changes**: Removed 3 items
|
||||
@ -70,12 +121,57 @@ Please continue from Session 1 Part 2: Fix hit location requirements.
|
||||
|
||||
---
|
||||
|
||||
## Next Steps (Session 1 Part 2)
|
||||
## Next Steps (Session 1 Part 4)
|
||||
|
||||
### Change #5: Fix Hit Location Requirements
|
||||
### Change #7: Remove Offensive Approach
|
||||
|
||||
**Current Problem**:
|
||||
`frontend-sba/components/Gameplay/ManualOutcomeEntry.vue:152` has:
|
||||
**Pattern**: Same as Part 3 (defensive alignment removal)
|
||||
|
||||
**Files to Modify**:
|
||||
|
||||
**Backend** (~5 files):
|
||||
1. `backend/app/models/game_models.py` - OffensiveDecision class
|
||||
- Remove `approach` field (currently line ~193)
|
||||
- Remove `validate_approach()` method if exists
|
||||
|
||||
2. `backend/terminal_client/display.py`
|
||||
- Remove approach from offensive decision display (~line 196-197)
|
||||
|
||||
3. `backend/app/core/ai_opponent.py`
|
||||
- Update offensive decision generation (remove approach)
|
||||
|
||||
4. `backend/tests/unit/models/test_game_models.py`
|
||||
- Remove approach-related tests
|
||||
|
||||
5. `backend/tests/unit/core/test_validators.py`
|
||||
- Remove approach validation test if exists
|
||||
|
||||
**Frontend** (~3 files):
|
||||
1. `frontend-sba/types/game.ts`
|
||||
- Remove `approach` field from OffensiveDecision interface
|
||||
|
||||
2. `frontend-sba/components/Decisions/OffensiveApproach.vue`
|
||||
- Remove "Batting Approach" section from template
|
||||
- Remove `approach` from localSetup
|
||||
- Remove approachOptions array
|
||||
- Remove approachDisplay computed
|
||||
- Remove approach from hasChanges
|
||||
|
||||
3. Check for any other usages:
|
||||
- Grep for `.approach` in frontend
|
||||
|
||||
**Note**: Offensive approach will be replaced in Session 3 (Change #10) with specific actions: swing_away, check_jump, hit_and_run, sac_bunt, squeeze_bunt. For now, just remove the unused field.
|
||||
|
||||
**Estimated Time**: 15-20 minutes
|
||||
|
||||
---
|
||||
|
||||
## Completed Steps
|
||||
|
||||
### Change #5: Fix Hit Location Requirements ✅ DONE
|
||||
|
||||
**Problem**:
|
||||
`frontend-sba/components/Gameplay/ManualOutcomeEntry.vue:152` had:
|
||||
```typescript
|
||||
const outcomesNeedingHitLocation = [
|
||||
'GROUNDOUT',
|
||||
|
||||
Loading…
Reference in New Issue
Block a user