From 4532dd671e7962a76c9440e899860588399ba8f3 Mon Sep 17 00:00:00 2001
From: Peter <peterlgirouard@gmail.com>
Date: Sat, 9 Nov 2024 10:01:11 -0600
Subject: [PATCH 1/6] Normalize pitching stats for fetchPitchingStatsBySeries
 and add fetchPitchingStatsForLastTwoWeeksByTeam

---
 src/services/pitchingStatsService.ts | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/src/services/pitchingStatsService.ts b/src/services/pitchingStatsService.ts
index 9ab0f79..cb9405a 100644
--- a/src/services/pitchingStatsService.ts
+++ b/src/services/pitchingStatsService.ts
@@ -241,6 +241,22 @@ export async function fetchPitchingStatsForLastFourGamesBySeasonAndPlayerId(seas
   return pitchingStatsResponse.stats.map(normalizePitchingStat)
 }
 
+export async function fetchPitchingStatsForLastTwoWeeksByTeam(seasonNumber: number, weekNumber: number, teamId: number): Promise<PitchingStat[]> {
+  // no support for pre-modern games yet
+  if (seasonNumber < MODERN_STAT_ERA_START) {
+    return []
+  }
+
+  const response = await fetch(`${SITE_URL}/api/v3/plays/pitching?season=${seasonNumber}&week_start=${weekNumber - 1}&week_end=${weekNumber}&team_id=${teamId}&group_by=playergame`)
+
+  const pitchingStatsResponse: {
+    count: number
+    stats: PitchingStatRaw[]
+  } = await response.json()
+
+  return pitchingStatsResponse.stats.map(normalizePitchingStat)
+}
+
 export async function fetchPitchingStatsBySeries(seasonNumber: number, weekNumber: number, homeTeamId: number, awayTeamId: number): Promise<PitchingStat[]> {
   // no support for pre-modern games yet
   if (seasonNumber < MODERN_STAT_ERA_START) {
@@ -251,10 +267,10 @@ export async function fetchPitchingStatsBySeries(seasonNumber: number, weekNumbe
 
   const pitchingStatsResponse: {
     count: number
-    stats: PitchingStat[]
+    stats: PitchingStatRaw[]
   } = await response.json()
 
-  return pitchingStatsResponse.stats
+  return pitchingStatsResponse.stats.map(normalizePitchingStat)
 }
 
 export function aggregatePitchingStats(pitchingStats: PitchingStat[]): PitchingStat {

From b991fbff983ea3fff21bdbbde7b08d53a5ed35e1 Mon Sep 17 00:00:00 2001
From: Peter <peterlgirouard@gmail.com>
Date: Sat, 9 Nov 2024 10:10:38 -0600
Subject: [PATCH 2/6] Add Bullpen Table POC

---
 components.d.ts                 |   1 +
 src/components/BullpenTable.vue | 117 ++++++++++++++++++++++++++++++++
 src/views/TeamView.vue          |   6 +-
 3 files changed, 123 insertions(+), 1 deletion(-)
 create mode 100644 src/components/BullpenTable.vue

diff --git a/components.d.ts b/components.d.ts
index 3bdcdd8..2aa0cfb 100644
--- a/components.d.ts
+++ b/components.d.ts
@@ -9,6 +9,7 @@ export {}
 
 declare module '@vue/runtime-core' {
   export interface GlobalComponents {
+    BullpenTable: typeof import('./src/components/BullpenTable.vue')['default']
     CardImagesDisplay: typeof import('./src/components/CardImagesDisplay.vue')['default']
     ExtendedStandingsTable: typeof import('./src/components/ExtendedStandingsTable.vue')['default']
     IconCommunity: typeof import('./src/components/icons/IconCommunity.vue')['default']
diff --git a/src/components/BullpenTable.vue b/src/components/BullpenTable.vue
new file mode 100644
index 0000000..9e28564
--- /dev/null
+++ b/src/components/BullpenTable.vue
@@ -0,0 +1,117 @@
+<template>
+  <div class="bullpen-table">
+    <div class="row">
+      <h3>Bullpen</h3>
+      <div class="table-responsive-xl">
+        <table class="table table-sm table-striped">
+          <thead class="thead-dark">
+            <tr>
+              <th>Name</th>
+              <th>Positions</th>
+              <th>W{{weekNumber - 1}}G1</th>
+              <th>W{{weekNumber - 1}}G2</th>
+              <th>W{{weekNumber - 1}}G3</th>
+              <th>W{{weekNumber - 1}}G4</th>
+              <th v-if="weekNumber - 1 > 18">W{{weekNumber - 1}}G5</th>
+              <th v-if="weekNumber - 1 > 19">W{{weekNumber - 1}}G6</th>
+              <th v-if="weekNumber - 1 > 19">W{{weekNumber - 1}}G7</th>
+              <th>W{{weekNumber}}G1</th>
+              <th>W{{weekNumber}}G2</th>
+              <th>W{{weekNumber}}G3</th>
+              <th>W{{weekNumber}}G4</th>
+              <th v-if="weekNumber > 18">W{{weekNumber}}G5</th>
+              <th v-if="weekNumber > 19">W{{weekNumber}}G6</th>
+              <th v-if="weekNumber > 19">W{{weekNumber}}G7</th>
+            </tr>
+          </thead>
+          <tbody>
+            <tr v-for="player in sortedPlayers" :key="player.name">
+              <td :title="player.il_return ? `Injured until ${player.il_return}` : ''">
+                {{ player.il_return ? '🏥' : '' }}
+                <RouterLink :to="{ name: 'player', params: { seasonNumber: seasonNumber, playerName: player.name } }">
+                  {{ player.name }}
+                </RouterLink>
+                {{ player.il_return ? '🏥' : '' }}
+              </td>
+              <td>
+                {{ allPositions(player) }}
+              </td>
+              <td>{{getIPForPitcherGame(player, weekNumber - 1, 1)}}</td>
+              <td>{{getIPForPitcherGame(player, weekNumber - 1, 2)}}</td>
+              <td>{{getIPForPitcherGame(player, weekNumber - 1, 3)}}</td>
+              <td>{{getIPForPitcherGame(player, weekNumber - 1, 4)}}</td>
+              <td v-if="weekNumber - 1 > 18">{{getIPForPitcherGame(player, weekNumber - 1, 5)}}</td>
+              <td v-if="weekNumber - 1 > 19">{{getIPForPitcherGame(player, weekNumber - 1, 6)}}</td>
+              <td v-if="weekNumber - 1 > 19">{{getIPForPitcherGame(player, weekNumber - 1, 7)}}</td>
+              <td>{{getIPForPitcherGame(player, weekNumber, 1)}}</td>
+              <td>{{getIPForPitcherGame(player, weekNumber, 2)}}</td>
+              <td>{{getIPForPitcherGame(player, weekNumber, 3)}}</td>
+              <td>{{getIPForPitcherGame(player, weekNumber, 4)}}</td>
+              <td v-if="weekNumber > 18">{{getIPForPitcherGame(player, weekNumber, 5)}}</td>
+              <td v-if="weekNumber > 19">{{getIPForPitcherGame(player, weekNumber, 6)}}</td>
+              <td v-if="weekNumber > 19">{{getIPForPitcherGame(player, weekNumber, 7)}}</td>
+            </tr>
+          </tbody>
+        </table>
+      </div>
+    </div>
+  </div>
+</template>
+
+<script lang="ts">
+import { type Game } from '@/services/apiResponseTypes'
+import { fetchPitchingStatsForLastTwoWeeksByTeam, type PitchingStat } from '@/services/pitchingStatsService'
+import { fetchPlayersByTeam, type Player } from '@/services/playersService'
+
+export default {
+  name: 'BullpenTable',
+  data() {
+    return {
+      pitcherStatsByNameWeekGame: {} as Record<string, PitchingStat>,
+      sortedPlayers: [] as Player[]
+    }
+  },
+  props: {
+    seasonNumber: { type: Number, required: true },
+    weekNumber: { type: Number, required: true },
+    teamId: { type: Number, required: true },
+  },
+  created() {
+    this.fetchData()
+  },
+  methods: {
+    async fetchData(): Promise<void> {
+      const pitcherStatsByGame: PitchingStat[] = await fetchPitchingStatsForLastTwoWeeksByTeam(this.seasonNumber, this.weekNumber, this.teamId)
+      const players: Player[] = await fetchPlayersByTeam(this.seasonNumber, this.teamId)
+      this.sortedPlayers = players.filter(p => ['SP', 'RP'].includes(p.pos_1)).sort(this.sortPitchers)
+      console.log(this.sortedPlayers)
+      this.pitcherStatsByNameWeekGame = Object.fromEntries(pitcherStatsByGame.map(stat => [this.recordKeySelector(stat), stat]))
+      console.log(this.pitcherStatsByNameWeekGame)
+    },
+    //sorts SP above RP and more expensive players up top
+    sortPitchers(p1: Player, p2: Player): number {
+      if (p1.pos_1 === p2.pos_1) return p2.wara - p1.wara
+
+      return p1.pos_1 === 'SP' ? -1 : 1
+    },
+    allPositions(player: Player): string {
+      let positions = []
+      positions.push(player.pos_1, player.pos_2, player.pos_3, player.pos_4, player.pos_5, player.pos_6, player.pos_7)
+      return positions.filter(p => p).join(' ')
+    },
+    recordKeySelector(stat: PitchingStat): string {
+      return `${stat.player.name}-${(stat.game as Game).week}-${(stat.game as Game).game_num}`
+    },
+    alternateRecordKeySelector(player: Player, weekNumber: number, gameNumber: number): string {
+      return `${player.name}-${weekNumber}-${gameNumber}`
+    },
+    getIPForPitcherGame(player: Player, weekNumber: number, gameNumber: number): string {
+      const key = this.alternateRecordKeySelector(player, weekNumber, gameNumber)
+      const stat: PitchingStat = this.pitcherStatsByNameWeekGame[key]
+      if (!stat) return '-'
+      
+      return `${stat?.ip.toFixed(1)}IP`
+    }
+  }
+}
+</script>
diff --git a/src/views/TeamView.vue b/src/views/TeamView.vue
index d346110..fbd359c 100644
--- a/src/views/TeamView.vue
+++ b/src/views/TeamView.vue
@@ -155,6 +155,8 @@
       </div>
     </div>
 
+    <BullpenTable v-if="weekNumber && team?.id" :season-number="seasonNumber" :week-number="weekNumber" :team-id="team.id" />
+
     <!-- Schedule -->
     <TeamScheduleTable v-if="!isFreeAgentTeam && team" :season-number="seasonNumber" :team-id="team.id" />
 
@@ -191,10 +193,12 @@ import TeamScheduleTable from '@/components/TeamScheduleTable.vue'
 import TeamPitchingTable from '@/components/TeamPitchingTable.vue'
 import TeamBattingTable from '@/components/TeamBattingTable.vue'
 import TeamFieldingTable from '@/components/TeamFieldingTable.vue'
+import BullpenTable from '@/components/BullpenTable.vue'
 
 export default {
   name: 'TeamView',
   components: {
+    BullpenTable,
     TeamScheduleTable,
     TeamPitchingTable,
     TeamBattingTable,
@@ -309,7 +313,7 @@ export default {
     allPositions(player: Player): string {
       let positions = []
       positions.push(player.pos_1, player.pos_2, player.pos_3, player.pos_4, player.pos_5, player.pos_6, player.pos_7)
-      return positions.join(' ')
+      return positions.filter(p => p).join(' ')
     },
     swarTotal(players: Player[]): number {
       return players.map(p => p.wara).reduce((prev, curr) => prev + curr, 0)

From 3f2b2869cabc0f29d17e1331a4db9ad0e7dac546 Mon Sep 17 00:00:00 2001
From: Peter <peterlgirouard@gmail.com>
Date: Sat, 9 Nov 2024 10:13:03 -0600
Subject: [PATCH 3/6] Rename method for future broader usage

---
 src/components/BullpenTable.vue | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/src/components/BullpenTable.vue b/src/components/BullpenTable.vue
index 9e28564..eaf4536 100644
--- a/src/components/BullpenTable.vue
+++ b/src/components/BullpenTable.vue
@@ -36,20 +36,20 @@
               <td>
                 {{ allPositions(player) }}
               </td>
-              <td>{{getIPForPitcherGame(player, weekNumber - 1, 1)}}</td>
-              <td>{{getIPForPitcherGame(player, weekNumber - 1, 2)}}</td>
-              <td>{{getIPForPitcherGame(player, weekNumber - 1, 3)}}</td>
-              <td>{{getIPForPitcherGame(player, weekNumber - 1, 4)}}</td>
-              <td v-if="weekNumber - 1 > 18">{{getIPForPitcherGame(player, weekNumber - 1, 5)}}</td>
-              <td v-if="weekNumber - 1 > 19">{{getIPForPitcherGame(player, weekNumber - 1, 6)}}</td>
-              <td v-if="weekNumber - 1 > 19">{{getIPForPitcherGame(player, weekNumber - 1, 7)}}</td>
-              <td>{{getIPForPitcherGame(player, weekNumber, 1)}}</td>
-              <td>{{getIPForPitcherGame(player, weekNumber, 2)}}</td>
-              <td>{{getIPForPitcherGame(player, weekNumber, 3)}}</td>
-              <td>{{getIPForPitcherGame(player, weekNumber, 4)}}</td>
-              <td v-if="weekNumber > 18">{{getIPForPitcherGame(player, weekNumber, 5)}}</td>
-              <td v-if="weekNumber > 19">{{getIPForPitcherGame(player, weekNumber, 6)}}</td>
-              <td v-if="weekNumber > 19">{{getIPForPitcherGame(player, weekNumber, 7)}}</td>
+              <td>{{getStatForPitcherGame(player, weekNumber - 1, 1)}}</td>
+              <td>{{getStatForPitcherGame(player, weekNumber - 1, 2)}}</td>
+              <td>{{getStatForPitcherGame(player, weekNumber - 1, 3)}}</td>
+              <td>{{getStatForPitcherGame(player, weekNumber - 1, 4)}}</td>
+              <td v-if="weekNumber - 1 > 18">{{getStatForPitcherGame(player, weekNumber - 1, 5)}}</td>
+              <td v-if="weekNumber - 1 > 19">{{getStatForPitcherGame(player, weekNumber - 1, 6)}}</td>
+              <td v-if="weekNumber - 1 > 19">{{getStatForPitcherGame(player, weekNumber - 1, 7)}}</td>
+              <td>{{getStatForPitcherGame(player, weekNumber, 1)}}</td>
+              <td>{{getStatForPitcherGame(player, weekNumber, 2)}}</td>
+              <td>{{getStatForPitcherGame(player, weekNumber, 3)}}</td>
+              <td>{{getStatForPitcherGame(player, weekNumber, 4)}}</td>
+              <td v-if="weekNumber > 18">{{getStatForPitcherGame(player, weekNumber, 5)}}</td>
+              <td v-if="weekNumber > 19">{{getStatForPitcherGame(player, weekNumber, 6)}}</td>
+              <td v-if="weekNumber > 19">{{getStatForPitcherGame(player, weekNumber, 7)}}</td>
             </tr>
           </tbody>
         </table>
@@ -105,12 +105,12 @@ export default {
     alternateRecordKeySelector(player: Player, weekNumber: number, gameNumber: number): string {
       return `${player.name}-${weekNumber}-${gameNumber}`
     },
-    getIPForPitcherGame(player: Player, weekNumber: number, gameNumber: number): string {
+    getStatForPitcherGame(player: Player, weekNumber: number, gameNumber: number): string {
       const key = this.alternateRecordKeySelector(player, weekNumber, gameNumber)
       const stat: PitchingStat = this.pitcherStatsByNameWeekGame[key]
       if (!stat) return '-'
       
-      return `${stat?.ip.toFixed(1)}IP`
+      return `${stat.ip.toFixed(1)}IP`
     }
   }
 }

From 1bc05eccc03c98582628b50be1d2ad5aa701994a Mon Sep 17 00:00:00 2001
From: Peter <peterlgirouard@gmail.com>
Date: Sat, 9 Nov 2024 11:43:57 -0600
Subject: [PATCH 4/6] Fix IDE warnings

---
 src/components/PlayerCareerBattingTable.vue | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/components/PlayerCareerBattingTable.vue b/src/components/PlayerCareerBattingTable.vue
index 882a677..026452f 100644
--- a/src/components/PlayerCareerBattingTable.vue
+++ b/src/components/PlayerCareerBattingTable.vue
@@ -36,7 +36,7 @@
             </tr>
           </thead>
           <tbody id="career-batting-table">
-            <tr v-for="stat in sortedRegularAndPostSeasonBatting">
+            <tr v-for="stat in sortedRegularAndPostSeasonBatting" :key="`${stat.seasonNumber}-${stat.isRegularSeason}`">
               <td>S{{ stat.seasonNumber }}{{ stat.isRegularSeason ? '' : ' / Playoffs' }}</td>
               <td>{{ stat.pa }}</td>
               <td>{{ stat.ab }}</td>
@@ -67,7 +67,7 @@
             </tr>
           </tbody>
           <tfoot>
-            <tr v-for="(stat, idx) in careerBattingStats">
+            <tr v-for="(stat, idx) in careerBattingStats" :key="idx">
               <th>Career{{ idx > 0 ? ' / Playoffs' : '' }}</th>
               <th>{{ stat.pa }}</th>
               <th>{{ stat.ab }}</th>
@@ -112,7 +112,7 @@ interface BattingStatWithSeason extends BattingStat {
 }
 
 export default {
-  name: "PlayerCareerBattingTable",
+  name: 'PlayerCareerBattingTable',
   props: {
     regularSeasonBattingStats: { type: Array<BattingStat>, required: true },
     postSeasonBattingStats: { type: Array<BattingStat>, required: true },

From a7e1f4a755109af152de4e6da3b0f53b52d3ec35 Mon Sep 17 00:00:00 2001
From: Peter <peterlgirouard@gmail.com>
Date: Sat, 9 Nov 2024 11:44:19 -0600
Subject: [PATCH 5/6] Show/hide bullpen

---
 src/components/BullpenTable.vue | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/src/components/BullpenTable.vue b/src/components/BullpenTable.vue
index eaf4536..a19ce63 100644
--- a/src/components/BullpenTable.vue
+++ b/src/components/BullpenTable.vue
@@ -1,7 +1,14 @@
 <template>
   <div class="bullpen-table">
     <div class="row">
-      <h3>Bullpen</h3>
+      <h3>Bullpen
+      <button @click.stop="setVisiblity(!showBullpen)"
+        class="btn btn-sm btn-primary mb-2">
+        {{ showBullpen ? 'Hide' : 'Show' }}
+      </button>
+      </h3>
+    </div>
+    <div class="row" v-if="showBullpen">
       <div class="table-responsive-xl">
         <table class="table table-sm table-striped">
           <thead class="thead-dark">
@@ -68,7 +75,8 @@ export default {
   data() {
     return {
       pitcherStatsByNameWeekGame: {} as Record<string, PitchingStat>,
-      sortedPlayers: [] as Player[]
+      sortedPlayers: [] as Player[],
+      showBullpen: false as boolean
     }
   },
   props: {
@@ -111,6 +119,9 @@ export default {
       if (!stat) return '-'
       
       return `${stat.ip.toFixed(1)}IP`
+    },
+    setVisiblity(state: boolean): void {
+      this.showBullpen = state
     }
   }
 }

From d2f4b5e168b32539d1ccd7beaa11a9aa1ab0fe45 Mon Sep 17 00:00:00 2001
From: Peter <peterlgirouard@gmail.com>
Date: Sat, 9 Nov 2024 12:03:13 -0600
Subject: [PATCH 6/6] Clean up console.log

---
 src/components/BullpenTable.vue | 2 --
 src/views/TransactionsView.vue  | 2 --
 2 files changed, 4 deletions(-)

diff --git a/src/components/BullpenTable.vue b/src/components/BullpenTable.vue
index a19ce63..d4a3ede 100644
--- a/src/components/BullpenTable.vue
+++ b/src/components/BullpenTable.vue
@@ -92,9 +92,7 @@ export default {
       const pitcherStatsByGame: PitchingStat[] = await fetchPitchingStatsForLastTwoWeeksByTeam(this.seasonNumber, this.weekNumber, this.teamId)
       const players: Player[] = await fetchPlayersByTeam(this.seasonNumber, this.teamId)
       this.sortedPlayers = players.filter(p => ['SP', 'RP'].includes(p.pos_1)).sort(this.sortPitchers)
-      console.log(this.sortedPlayers)
       this.pitcherStatsByNameWeekGame = Object.fromEntries(pitcherStatsByGame.map(stat => [this.recordKeySelector(stat), stat]))
-      console.log(this.pitcherStatsByNameWeekGame)
     },
     //sorts SP above RP and more expensive players up top
     sortPitchers(p1: Player, p2: Player): number {
diff --git a/src/views/TransactionsView.vue b/src/views/TransactionsView.vue
index 0d03b0f..3982206 100644
--- a/src/views/TransactionsView.vue
+++ b/src/views/TransactionsView.vue
@@ -150,9 +150,7 @@ export default {
     },
     async fetchData(): Promise<void> {
       this.weekTransactions = await fetchTransactionsByWeek(this.seasonNumber, this.selectedWeekNumber)
-      console.log('curr', this.weekTransactions)
       this.nextWeekTransactions = await fetchTransactionsByWeek(this.seasonNumber, this.selectedWeekNumber + 1)
-      console.log('next', this.nextWeekTransactions)
     }
   }
 }