From ef270ec1ab375ec6e031a5f505508e846057b609 Mon Sep 17 00:00:00 2001 From: Cal Corum Date: Mon, 6 Apr 2026 14:59:56 -0500 Subject: [PATCH 1/2] fix: remove stale "Rating Boosts coming soon" from Superfractor notification MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Tier boosts shipped in Phase 2 — the teaser field in the T4 tier-up embed was outdated. Remove it and update tests + test plan to match. Co-Authored-By: Claude Opus 4.6 (1M context) --- helpers/refractor_notifs.py | 5 ---- tests/refractor-integration-test-plan.md | 2 -- tests/test_refractor_notifs.py | 31 +++--------------------- 3 files changed, 3 insertions(+), 35 deletions(-) diff --git a/helpers/refractor_notifs.py b/helpers/refractor_notifs.py index 53417ee..a609ce6 100644 --- a/helpers/refractor_notifs.py +++ b/helpers/refractor_notifs.py @@ -63,11 +63,6 @@ def build_tier_up_embed(tier_up: dict) -> discord.Embed: ), color=color, ) - embed.add_field( - name="Rating Boosts", - value="Rating boosts coming in a future update!", - inline=False, - ) else: embed = discord.Embed( title="Refractor Tier Up!", diff --git a/tests/refractor-integration-test-plan.md b/tests/refractor-integration-test-plan.md index d9bd5d4..e12d4fe 100644 --- a/tests/refractor-integration-test-plan.md +++ b/tests/refractor-integration-test-plan.md @@ -542,10 +542,8 @@ REF-55, REF-60 through REF-64) can be validated via API calls and bot logs. | | - Title: "SUPERFRACTOR!" (not "Refractor Tier Up!") | | | - Description: `**{Player Name}** has reached maximum refractor tier on the **{Track Name}** track` | | | - Color: teal (`0x1ABC9C`) | -| | - Extra field: "Rating Boosts" with value "Rating boosts coming in a future update!" | | **Pass criteria** | 1. Title is "SUPERFRACTOR!" | | | 2. Description mentions "maximum refractor tier" | -| | 3. "Rating Boosts" field is present | ### REF-63: Multiple tier-ups in one game | Field | Value | diff --git a/tests/test_refractor_notifs.py b/tests/test_refractor_notifs.py index 20bf2ac..b93e225 100644 --- a/tests/test_refractor_notifs.py +++ b/tests/test_refractor_notifs.py @@ -143,36 +143,11 @@ class TestBuildTierUpEmbedSuperfractor: embed = build_tier_up_embed(tier_up) assert embed.color.value == 0x1ABC9C - def test_note_field_present(self): - """Tier 4 must include a note field about future rating boosts.""" + def test_no_extra_fields(self): + """Tier 4 embed should have no extra fields — boosts are live, no teaser needed.""" tier_up = make_tier_up(old_tier=3, new_tier=4) embed = build_tier_up_embed(tier_up) - field_names = [f.name for f in embed.fields] - assert any( - "rating" in name.lower() - or "boost" in name.lower() - or "note" in name.lower() - for name in field_names - ), "Expected a field mentioning rating boosts for tier 4 embed" - - def test_note_field_value_mentions_future_update(self): - """The note field value must reference the future rating boost update.""" - tier_up = make_tier_up(old_tier=3, new_tier=4) - embed = build_tier_up_embed(tier_up) - note_field = next( - ( - f - for f in embed.fields - if "rating" in f.name.lower() - or "boost" in f.name.lower() - or "note" in f.name.lower() - ), - None, - ) - assert note_field is not None - assert ( - "future" in note_field.value.lower() or "update" in note_field.value.lower() - ) + assert len(embed.fields) == 0 def test_footer_text_is_paper_dynasty_refractor(self): """Footer must remain 'Paper Dynasty Refractor' for tier 4 as well.""" -- 2.25.1 From 80e99b075f3f15873ad9beb6937ae2a62bd5f7aa Mon Sep 17 00:00:00 2001 From: Cal Corum Date: Mon, 6 Apr 2026 15:09:21 -0500 Subject: [PATCH 2/2] chore: fix stale docstring referencing removed note field Co-Authored-By: Claude Opus 4.6 (1M context) --- tests/test_refractor_notifs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_refractor_notifs.py b/tests/test_refractor_notifs.py index b93e225..41dc452 100644 --- a/tests/test_refractor_notifs.py +++ b/tests/test_refractor_notifs.py @@ -3,7 +3,7 @@ Tests for Refractor Tier Completion Notification embeds. These tests verify that: 1. Tier-up embeds are correctly formatted for tiers 1-3 (title, description, color). -2. Tier 4 (Superfractor) embeds include the special title, description, and note field. +2. Tier 4 (Superfractor) embeds include the special title, description, and color. 3. Multiple tier-up events each produce a separate embed. 4. An empty tier-up list results in no channel sends. -- 2.25.1