Strengthen players_refactor tests to assert on actual cog method calls #39

New Issue

cal · 2026-02-20T06:52:44Z

cal commented

2026-02-20 06:52:44 +00:00

tests/players_refactor/test_team_management.py:500-524 — Tests patch api_calls.db_get, call the mock directly, catch the exception, and pass. The actual cog method is never invoked. Tests pass even if the cog code is deleted.

`tests/players_refactor/test_team_management.py:500-524` — Tests patch `api_calls.db_get`, call the mock directly, catch the exception, and pass. The actual cog method is never invoked. Tests pass even if the cog code is deleted.

cal added the

tech-debt

label 2026-02-20 06:52:44 +00:00

cal added the

ai-working

label 2026-03-05 08:31:02 +00:00

cal referenced this issue from a commit

2026-03-05 08:35:00 +00:00

fix: invoke actual cog callback in test_error_handling_and_logging (#39)

cal referenced a pull request that will close this issue

2026-03-05 08:35:12 +00:00

fix: invoke actual cog callback in test_error_handling_and_logging (#39) #54

cal removed the

ai-working

label 2026-03-05 08:35:17 +00:00

cal commented

2026-03-05 08:35:24 +00:00

Opened PR #54 to fix this.

Approach: The no-op test body (which called mocks directly and swallowed exceptions without ever touching the cog) was replaced with a test that:

Fetches pull_roster_command.callback from the real cog instance
Patches get_context_user, get_team_by_owner, and get_rosters at cogs.players_new.team_management.*
Configures get_rosters to raise Exception("Connection error")
Calls the callback and asserts ctx.send received 'Could not retrieve rosters from your sheet.'

The test skips gracefully if TeamManagement can't be imported. It will fail if the method body or exception handler is deleted.

Opened PR #54 to fix this. **Approach:** The no-op test body (which called mocks directly and swallowed exceptions without ever touching the cog) was replaced with a test that: 1. Fetches `pull_roster_command.callback` from the real cog instance 2. Patches `get_context_user`, `get_team_by_owner`, and `get_rosters` at `cogs.players_new.team_management.*` 3. Configures `get_rosters` to raise `Exception("Connection error")` 4. Calls the callback and asserts `ctx.send` received `'Could not retrieve rosters from your sheet.'` The test skips gracefully if `TeamManagement` can't be imported. It will fail if the method body or exception handler is deleted.

cal added the

ai-pr-opened

label 2026-03-05 08:35:24 +00:00

cal referenced this issue from a commit

2026-03-07 07:34:03 +00:00

fix: invoke actual cog callback in test_error_handling_and_logging (#39)

cal closed this issue

2026-03-07 07:41:29 +00:00

cal referenced this issue from a commit

2026-03-07 07:41:32 +00:00

Merge pull request 'fix: invoke actual cog callback in test_error_handling_and_logging (#39)' (#54) from ai/paper-dynasty-discord-39 into next-release

cal referenced this issue