cal/paper-dynasty-discord
1
0
Fork 0
Code Issues 14 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Remove top-level discord_utils.py duplicate #34

New Issue
Closed
opened 2026-02-20 06:52:17 +00:00 by cal · 2 comments
cal commented 2026-02-20 06:52:17 +00:00
Owner
Copy Link

Both files are exactly 251 lines. No production code imports discord_utils directly (only the helpers package). Top-level file is a dead duplicate.

Both files are exactly 251 lines. No production code imports `discord_utils` directly (only the `helpers` package). Top-level file is a dead duplicate.
cal added the
tech-debt
 label 2026-02-20 06:52:17 +00:00
cal added the
ai-working
 label 2026-03-05 12:31:06 +00:00
cal removed the
ai-working
 label 2026-03-05 12:35:49 +00:00
cal commented 2026-03-05 12:35:53 +00:00
Author
Owner
Copy Link

PR #62 opened: #62

Fix approach:

  • Deleted discord_utils.py (top-level duplicate)
  • Updated helpers/main.py: from discord_utils import * → from .discord_utils import * (relative import into helpers/discord_utils.py)
  • Updated helpers.py: from discord_utils import * → from helpers.discord_utils import *

Note: helpers.py is effectively superseded by the helpers/ package (Python loads the package, not the module), but the import was corrected for consistency.

PR #62 opened: https://git.manticorum.com/cal/paper-dynasty-discord/pulls/62 **Fix approach:** - Deleted `discord_utils.py` (top-level duplicate) - Updated `helpers/main.py`: `from discord_utils import *` → `from .discord_utils import *` (relative import into `helpers/discord_utils.py`) - Updated `helpers.py`: `from discord_utils import *` → `from helpers.discord_utils import *` Note: `helpers.py` is effectively superseded by the `helpers/` package (Python loads the package, not the module), but the import was corrected for consistency.
cal added the
ai-pr-opened
 label 2026-03-05 12:35:56 +00:00
cal commented 2026-03-23 04:28:16 +00:00
Author
Owner
Copy Link

PR #105 addresses this: #105

Deleted the top-level discord_utils.py (251 lines). Fixed helpers/main.py line 36: changed from discord_utils import * to from .discord_utils import * (relative import within the package). No other live code files had bare from discord_utils import references.

PR #105 addresses this: https://git.manticorum.com/cal/paper-dynasty-discord/pulls/105 Deleted the top-level `discord_utils.py` (251 lines). Fixed `helpers/main.py` line 36: changed `from discord_utils import *` to `from .discord_utils import *` (relative import within the package). No other live code files had bare `from discord_utils import` references.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ai-changes-requested

   
ai-failed

   
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-working

   
ai-working

   
bug

   
enhancement

   
feature

New feature proposal

  
in-queue

Approved for development

  
performance

   
security

   
tech-debt

   
todo
No Label
ai-changes-requested
ai-failed
ai-pr-opened
ai-reviewed
ai-reviewing
ai-working
ai-working
bug
enhancement
feature
in-queue
performance
security
tech-debt
todo
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-discord#34
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?