cal/paper-dynasty-discord
1
0
Fork 0
Code Issues 14 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Remove top-level helpers.py after migration to helpers/ package #33

New Issue
Closed
opened 2026-02-20 06:52:11 +00:00 by cal · 2 comments
cal commented 2026-02-20 06:52:11 +00:00
Owner
Copy Link

Both helpers.py and helpers/main.py are 2153/2155 lines with identical function signatures. Creates confusion about which is canonical, doubles maintenance burden, and bug fixes may be applied to one but not the other.

Both `helpers.py` and `helpers/main.py` are 2153/2155 lines with identical function signatures. Creates confusion about which is canonical, doubles maintenance burden, and bug fixes may be applied to one but not the other.
cal added the
tech-debt
 label 2026-02-20 06:52:11 +00:00
cal added the
ai-working
 label 2026-03-05 14:31:25 +00:00
cal removed the
ai-working
 label 2026-03-05 14:32:41 +00:00
cal commented 2026-03-05 14:32:45 +00:00
Author
Owner
Copy Link

PR #65 opens the fix: #65

Approach: Simply deleted helpers.py (2153 lines). Python's module resolution always prefers the helpers/ package (directory with __init__.py) over helpers.py, so the file was never reachable at runtime. No caller changes needed — all import helpers / from helpers import ... statements already resolve to the package.

PR #65 opens the fix: https://git.manticorum.com/cal/paper-dynasty-discord/pulls/65 **Approach:** Simply deleted `helpers.py` (2153 lines). Python's module resolution always prefers the `helpers/` package (directory with `__init__.py`) over `helpers.py`, so the file was never reachable at runtime. No caller changes needed — all `import helpers` / `from helpers import ...` statements already resolve to the package.
cal added the
ai-pr-opened
 label 2026-03-05 14:32:48 +00:00
cal commented 2026-03-23 04:28:13 +00:00
Author
Owner
Copy Link

PR #105 addresses this: #105

Deleted the top-level helpers.py (2153 lines). All imports in the codebase already use from helpers import ... or from helpers.xxx import ... (package form), so no import fixes were needed. Python's module resolution always preferred the helpers/ package over the top-level file anyway.

PR #105 addresses this: https://git.manticorum.com/cal/paper-dynasty-discord/pulls/105 Deleted the top-level `helpers.py` (2153 lines). All imports in the codebase already use `from helpers import ...` or `from helpers.xxx import ...` (package form), so no import fixes were needed. Python's module resolution always preferred the `helpers/` package over the top-level file anyway.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ai-changes-requested

   
ai-failed

   
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-working

   
ai-working

   
bug

   
enhancement

   
feature

New feature proposal

  
in-queue

Approved for development

  
performance

   
security

   
tech-debt

   
todo
No Label
ai-changes-requested
ai-failed
ai-pr-opened
ai-reviewed
ai-reviewing
ai-working
ai-working
bug
enhancement
feature
in-queue
performance
security
tech-debt
todo
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-discord#33
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?