cal/paper-dynasty-discord
1
0
Fork 0
Code Issues 14 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Remove duplicate sheets.open_by_key() call in get_full_roster_from_sheets #30

New Issue
Closed
opened 2026-02-20 06:51:55 +00:00 by cal · 1 comment
cal commented 2026-02-20 06:51:55 +00:00
Owner
Copy Link

command_logic/logic_gameplay.py:1159-1161. sheets.open_by_key(this_team.gsheet) called twice back-to-back with no logic between. Unnecessary Google Sheets API round-trip.

`command_logic/logic_gameplay.py:1159-1161`. `sheets.open_by_key(this_team.gsheet)` called twice back-to-back with no logic between. Unnecessary Google Sheets API round-trip.
cal added the
performance
bug
 labels 2026-02-20 06:51:55 +00:00
cal added the
ai-working
 label 2026-03-05 09:30:58 +00:00
cal added
ai-pr-opened
 and removed
ai-working
 labels 2026-03-05 09:32:53 +00:00
cal commented 2026-03-05 09:32:54 +00:00
Author
Owner
Copy Link

Opened PR #56 to fix this: #56

Removed the duplicate sheets.open_by_key(this_team.gsheet) call on line 1161, eliminating the unnecessary Google Sheets API round-trip.

Opened PR #56 to fix this: https://git.manticorum.com/cal/paper-dynasty-discord/pulls/56 Removed the duplicate `sheets.open_by_key(this_team.gsheet)` call on line 1161, eliminating the unnecessary Google Sheets API round-trip.
cal closed this issue 2026-03-10 18:26:31 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ai-changes-requested

   
ai-failed

   
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-working

   
ai-working

   
bug

   
enhancement

   
feature

New feature proposal

  
in-queue

Approved for development

  
performance

   
security

   
tech-debt

   
todo
No Label
ai-changes-requested
ai-failed
ai-pr-opened
ai-reviewed
ai-reviewing
ai-working
ai-working
bug
enhancement
feature
in-queue
performance
security
tech-debt
todo
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-discord#30
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?