cal/paper-dynasty-discord
1
0
Fork 0
Code Issues 14 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Add aiohttp.ClientError handling to all API call functions #29

New Issue
Closed
opened 2026-02-20 06:51:49 +00:00 by cal · 1 comment
cal commented 2026-02-20 06:51:49 +00:00
Owner
Copy Link

api_calls.py catches asyncio.TimeoutError but not aiohttp.ClientConnectionError or aiohttp.ClientResponseError. DNS failure or refused connection raises unformatted error to Discord user.

`api_calls.py` catches `asyncio.TimeoutError` but not `aiohttp.ClientConnectionError` or `aiohttp.ClientResponseError`. DNS failure or refused connection raises unformatted error to Discord user.
cal added the
bug
 label 2026-02-20 06:51:49 +00:00
cal added the
ai-working
 label 2026-03-05 10:01:07 +00:00
cal removed the
ai-working
 label 2026-03-05 10:03:34 +00:00
cal commented 2026-03-05 10:03:37 +00:00
Author
Owner
Copy Link

PR opened: #57

Added except aiohttp.ClientError as e handlers to all five API functions (db_get, db_patch, db_post, db_put, db_delete). Each handler logs the error and raises DatabaseError so callers get a consistent, formatted exception instead of a raw aiohttp error bubbling up to Discord users.

PR opened: https://git.manticorum.com/cal/paper-dynasty-discord/pulls/57 Added `except aiohttp.ClientError as e` handlers to all five API functions (`db_get`, `db_patch`, `db_post`, `db_put`, `db_delete`). Each handler logs the error and raises `DatabaseError` so callers get a consistent, formatted exception instead of a raw aiohttp error bubbling up to Discord users.
cal added the
ai-pr-opened
 label 2026-03-05 10:03:43 +00:00
cal closed this issue 2026-03-10 18:26:30 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ai-changes-requested

   
ai-failed

   
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-working

   
ai-working

   
bug

   
enhancement

   
feature

New feature proposal

  
in-queue

Approved for development

  
performance

   
security

   
tech-debt

   
todo
No Label
ai-changes-requested
ai-failed
ai-pr-opened
ai-reviewed
ai-reviewing
ai-working
ai-working
bug
enhancement
feature
in-queue
performance
security
tech-debt
todo
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-discord#29
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?