Fix potential NameError on db_game when db_post fails in complete_game #27

New Issue

cal · 2026-02-20T06:51:38Z

cal commented

2026-02-20 06:51:38 +00:00

command_logic/logic_gameplay.py:4284-4290. If db_game = await db_post("games", ...) raises, the except block references db_game["id"] for rollback — but db_game was never assigned. Masks the original error and prevents rollback.

`command_logic/logic_gameplay.py:4284-4290`. If `db_game = await db_post("games", ...)` raises, the `except` block references `db_game["id"]` for rollback — but `db_game` was never assigned. Masks the original error and prevents rollback.

cal added the

bug

label 2026-02-20 06:51:38 +00:00

cal added the

ai-working

label 2026-03-05 11:01:15 +00:00

cal referenced this issue from a commit

2026-03-05 11:03:09 +00:00

fix: guard roll_back against NameError when db_post fails in complete_game (#27)

cal referenced a pull request that will close this issue

2026-03-05 11:03:19 +00:00

fix: guard roll_back against NameError when db_post fails in complete_game (#27) #59

cal commented

2026-03-05 11:03:31 +00:00

PR #59 opens the fix: #59

Approach: Initialized db_game = None before the try block, then guarded the roll_back(db_game["id"]) call in the except with if db_game is not None:. If db_post raises before db_game is ever assigned, the except clause now skips the rollback (there's nothing to roll back) and lets log_exception record the real error — no NameError, no masked exception.

PR #59 opens the fix: https://git.manticorum.com/cal/paper-dynasty-discord/pulls/59 **Approach:** Initialized `db_game = None` before the `try` block, then guarded the `roll_back(db_game["id"])` call in the `except` with `if db_game is not None:`. If `db_post` raises before `db_game` is ever assigned, the except clause now skips the rollback (there's nothing to roll back) and lets `log_exception` record the real error — no `NameError`, no masked exception.

cal added

ai-pr-opened

and removed

ai-working

labels 2026-03-05 11:03:38 +00:00

cal referenced this issue from a commit

2026-03-07 07:33:39 +00:00

fix: guard roll_back against NameError when db_post fails in complete_game (#27)

cal removed the

ai-pr-opened

label 2026-03-10 14:10:30 +00:00

cal commented

2026-03-10 14:11:05 +00:00

PR previously submitted included 15 modified files, likely catching other active work. PR has been closed without prejudice.

Claude added the

ai-working

label 2026-03-10 15:31:07 +00:00

cal referenced this issue from a commit

2026-03-10 15:32:56 +00:00

fix: guard db_game against NameError when db_post fails in complete_game (#27)

Claude referenced a pull request that will close this issue

2026-03-10 15:33:05 +00:00

fix: guard db_game against NameError when db_post fails in complete_game (#27) #86

Claude removed the

ai-working

label 2026-03-10 15:33:11 +00:00

Claude commented

2026-03-10 15:33:14 +00:00

PR #86 opened: #86

Fix: added db_game = None before the try block and guarded roll_back(db_game["id"]) with if db_game is not None: — prevents NameError from masking the original exception when db_post("games") raises before assignment.

PR #86 opened: https://git.manticorum.com/cal/paper-dynasty-discord/pulls/86 Fix: added `db_game = None` before the try block and guarded `roll_back(db_game["id"])` with `if db_game is not None:` — prevents `NameError` from masking the original exception when `db_post("games")` raises before assignment.

Claude added the

ai-pr-opened

label 2026-03-10 15:33:17 +00:00

Claude closed this issue

2026-03-23 03:58:35 +00:00

Claude referenced this issue from a commit

2026-03-23 03:58:36 +00:00

Merge pull request 'fix: guard db_game against NameError when db_post fails in complete_game (#27)' (#86) from ai/paper-dynasty-discord27 into main

Sign in to join this conversation.