cal/paper-dynasty-discord
1
0
Fork 0
Code Issues 14 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Add get_away_team and get_home_team methods to StratGame dataclass #21

New Issue
Closed
opened 2026-02-20 06:51:02 +00:00 by cal · 2 comments
cal commented 2026-02-20 06:51:02 +00:00
Owner
Copy Link

db_calls_gameplay.py:190 has # TODO: add get_away_team and get_home_team that deals with SBa/PD and returns Team object. Callers must repeat team-lookup logic inline everywhere.

`db_calls_gameplay.py:190` has `# TODO: add get_away_team and get_home_team that deals with SBa/PD and returns Team object`. Callers must repeat team-lookup logic inline everywhere.
cal added the
tech-debt
todo
 labels 2026-02-20 06:51:02 +00:00
cal added the
ai-working
 label 2026-03-05 15:31:09 +00:00
cal removed the
ai-working
 label 2026-03-05 15:34:33 +00:00
cal commented 2026-03-05 15:34:34 +00:00
Author
Owner
Copy Link

Implemented in PR #67: #67

Added get_away_team() and get_home_team() async methods to StratGame. Both delegate to the existing get_game_team() function which already handles the SBA vs PD distinction — so callers no longer need to repeat the team-lookup logic inline.

Implemented in PR #67: https://git.manticorum.com/cal/paper-dynasty-discord/pulls/67 Added `get_away_team()` and `get_home_team()` async methods to `StratGame`. Both delegate to the existing `get_game_team()` function which already handles the SBA vs PD distinction — so callers no longer need to repeat the team-lookup logic inline.
cal added the
ai-pr-opened
 label 2026-03-05 15:34:43 +00:00
cal commented 2026-03-23 04:31:50 +00:00
Author
Owner
Copy Link

Fixed in PR #106. Added get_away_team() and get_home_team() async methods to the StratGame dataclass in db_calls_gameplay.py. Each delegates to get_game_team(self, team_id=self.away_team_id/home_team_id). Also removed the stale TODO comment from the Game model.

Fixed in PR #106. Added `get_away_team()` and `get_home_team()` async methods to the `StratGame` dataclass in `db_calls_gameplay.py`. Each delegates to `get_game_team(self, team_id=self.away_team_id/home_team_id)`. Also removed the stale TODO comment from the `Game` model.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ai-changes-requested

   
ai-failed

   
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-working

   
ai-working

   
bug

   
enhancement

   
feature

New feature proposal

  
in-queue

Approved for development

  
performance

   
security

   
tech-debt

   
todo
No Label
ai-changes-requested
ai-failed
ai-pr-opened
ai-reviewed
ai-reviewing
ai-working
ai-working
bug
enhancement
feature
in-queue
performance
security
tech-debt
todo
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-discord#21
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?