cal/paper-dynasty-discord
1
0
Fork 0
Code Issues 14 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Finish migration of daily check-in command to discord.Interaction #19

New Issue
Closed
opened 2026-02-20 06:50:49 +00:00 by cal · 2 comments
cal commented 2026-02-20 06:50:49 +00:00
Owner
Copy Link

cogs/economy.py:558 has # TODO: complete the migration to an interaction. Surrounding code uses interaction.edit_original_response, but the full code path was not migrated from the legacy context-based pattern.

`cogs/economy.py:558` has `# TODO: complete the migration to an interaction`. Surrounding code uses `interaction.edit_original_response`, but the full code path was not migrated from the legacy context-based pattern.
cal added the
tech-debt
todo
 labels 2026-02-20 06:50:49 +00:00
cal added the
ai-working
ai-working
 labels 2026-03-05 20:02:24 +00:00
cal removed the
ai-working
 label 2026-03-05 20:04:44 +00:00
cal commented 2026-03-05 20:04:48 +00:00
Author
Owner
Copy Link

PR opened: #69

Fix: Removed the greeting = assignment pattern (ctx-era idiom) from both branches of daily_checkin, and replaced await greeting.edit(...) with await interaction.edit_original_response(...). Also removed the TODO comment. The function now uses interaction.edit_original_response() consistently throughout.

PR opened: https://git.manticorum.com/cal/paper-dynasty-discord/pulls/69 **Fix:** Removed the `greeting =` assignment pattern (ctx-era idiom) from both branches of `daily_checkin`, and replaced `await greeting.edit(...)` with `await interaction.edit_original_response(...)`. Also removed the TODO comment. The function now uses `interaction.edit_original_response()` consistently throughout.
cal added the
ai-pr-opened
 label 2026-03-05 20:04:52 +00:00
cal commented 2026-03-23 04:35:23 +00:00
Author
Owner
Copy Link

Fixed in PR #107 (fix/checkin-and-paperdex-fixes).

The two greeting = assignments were removed so edit_original_response() is called directly, and the one remaining await greeting.edit(...) call was replaced with await interaction.edit_original_response(...). The TODO comment was also removed.

Fixed in PR #107 (`fix/checkin-and-paperdex-fixes`). The two `greeting =` assignments were removed so `edit_original_response()` is called directly, and the one remaining `await greeting.edit(...)` call was replaced with `await interaction.edit_original_response(...)`. The TODO comment was also removed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ai-changes-requested

   
ai-failed

   
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-working

   
ai-working

   
bug

   
enhancement

   
feature

New feature proposal

  
in-queue

Approved for development

  
performance

   
security

   
tech-debt

   
todo
No Label
ai-changes-requested
ai-failed
ai-pr-opened
ai-reviewed
ai-reviewing
ai-working
ai-working
bug
enhancement
feature
in-queue
performance
security
tech-debt
todo
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-discord#19
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?