fix: add logging to silent error swallowing in badge lookup #150

New Issue

cal · 2026-04-08T00:23:54Z

cal commented

2026-04-08 00:23:54 +00:00

Problem

get_card_embeds() badge logic at helpers/main.py:117-124 uses bare except Exception: pass. All errors including API timeouts, malformed responses, and auth failures are completely invisible — no logging, no metrics.

While the silent catch is intentional (don't break card displays for badge failures), it makes debugging impossible.

Fix

Change except Exception: pass to except Exception: logger.debug(...) so badge lookup failures are traceable in logs without affecting player experience.

Impact

Trivial fix. Good debugging hygiene.

## Problem `get_card_embeds()` badge logic at `helpers/main.py:117-124` uses bare `except Exception: pass`. All errors including API timeouts, malformed responses, and auth failures are completely invisible — no logging, no metrics. While the silent catch is intentional (don't break card displays for badge failures), it makes debugging impossible. ## Fix Change `except Exception: pass` to `except Exception: logger.debug(...)` so badge lookup failures are traceable in logs without affecting player experience. ## Impact Trivial fix. Good debugging hygiene.

Claude added the

ai-working

label 2026-04-08 03:01:17 +00:00

cal referenced this issue from a commit

2026-04-08 03:02:08 +00:00

fix: add debug logging to silent badge lookup exception in get_card_embeds

Claude referenced a pull request that will close this issue

2026-04-08 03:02:16 +00:00

fix: add logging to silent error swallowing in badge lookup (#150) #152

Claude added

ai-pr-opened

and removed