test: mock-based integration tests for post-game refractor hook #148

New Issue

cal · 2026-04-08T00:23:47Z

cal commented

2026-04-08 00:23:47 +00:00

Problem

Post-game hook tests (REF-50+) and tier-up notification tests (REF-60+) require a live game to test end-to-end. No automated tests cover the actual post-game flow: season-stats update → evaluate-game call → notification dispatch → variant render trigger.

The hook at logic_gameplay.py:4374-4387 is wrapped in try/except with a warning log, so failures are silent in production.

Proposed Approach

Create mock-based integration tests that simulate the post-game flow:

Mock db_post("season-stats/update-game/...") returning success
Mock db_post("refractor/evaluate-game/...") returning tier-up data
Verify notify_tier_completion is called with correct arguments
Verify _trigger_variant_renders is called for tier-ups with variant_created

This can run in CI without a live game and catches regressions in the orchestration logic.

## Problem Post-game hook tests (REF-50+) and tier-up notification tests (REF-60+) require a live game to test end-to-end. No automated tests cover the actual post-game flow: season-stats update → evaluate-game call → notification dispatch → variant render trigger. The hook at `logic_gameplay.py:4374-4387` is wrapped in try/except with a warning log, so failures are silent in production. ## Proposed Approach Create mock-based integration tests that simulate the post-game flow: 1. Mock `db_post("season-stats/update-game/...")` returning success 2. Mock `db_post("refractor/evaluate-game/...")` returning tier-up data 3. Verify `notify_tier_completion` is called with correct arguments 4. Verify `_trigger_variant_renders` is called for tier-ups with `variant_created` This can run in CI without a live game and catches regressions in the orchestration logic.

Claude added the

ai-working

label 2026-04-08 13:31:18 +00:00

Claude added the

ai-working

label 2026-04-08 13:33:26 +00:00

cal referenced this issue from a commit

2026-04-08 13:34:57 +00:00

test: mock-based integration tests for post-game refractor hook (#148)

Claude referenced a pull request that will close this issue

2026-04-08 13:35:08 +00:00

test: mock-based integration tests for post-game refractor hook (#148) #158

Claude added the

ai-pr-opened

label 2026-04-08 13:35:14 +00:00

Claude commented

2026-04-08 13:35:18 +00:00

PR #158 opened: #158

Approach: Extracted the inline try/except block from complete_game() (lines 4374–4387) into _run_post_game_refractor_hook(db_game_id, channel). This makes the hook directly testable without wiring up a full game session.

Added 13 tests in tests/test_post_game_refractor_hook.py covering:

Endpoint ordering (season-stats before evaluate)
notify_tier_completion called once per tier-up with correct channel
_trigger_variant_renders called with full tier_ups list
No notifications/renders on empty or absent tier_ups
Non-fatal: exceptions from any step don't propagate

PR #158 opened: https://git.manticorum.com/cal/paper-dynasty-discord/pulls/158 **Approach**: Extracted the inline `try/except` block from `complete_game()` (lines 4374–4387) into `_run_post_game_refractor_hook(db_game_id, channel)`. This makes the hook directly testable without wiring up a full game session. Added 13 tests in `tests/test_post_game_refractor_hook.py` covering: - Endpoint ordering (season-stats before evaluate) - notify_tier_completion called once per tier-up with correct channel - _trigger_variant_renders called with full tier_ups list - No notifications/renders on empty or absent tier_ups - Non-fatal: exceptions from any step don't propagate

Claude removed the

ai-working

label 2026-04-08 13:35:23 +00:00

cal closed this issue

2026-04-08 14:26:08 +00:00

cal referenced this issue from a commit

2026-04-08 14:26:09 +00:00

Merge pull request 'test: mock-based integration tests for post-game refractor hook (#148)' (#158) from issue/148-test-mock-based-integration-tests-for-post-game-re into main

Sign in to join this conversation.