feat: tier-up notification should include refractor card image #144
Labels
No Label
ai-changes-requested
ai-failed
ai-pr-opened
ai-reviewed
ai-reviewing
ai-working
ai-working
bug
enhancement
feature
in-queue
performance
security
tech-debt
todo
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cal/paper-dynasty-discord#144
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
build_tier_up_embed()inhelpers/refractor_notifs.pysends a text-only embed with title, description, and footer. No card image, no team branding, no visual payoff.The tier-up moment is the peak emotional payoff of the entire refractor progression loop. A text-only notification undersells it dramatically compared to the full card art visible via
/player refractor_tier:N.Fix
The
evaluate-gameAPI response already includesvariant_createdandplayer_id. The notification builder should:image_url)set_image()Impact
High UX value, low-medium effort. This is the single most important engagement touchpoint in the refractor loop.
Implemented in PR #159.
Approach:
_trigger_variant_renders()now returns aplayer_id → image_urldict from the render endpoint responses._run_post_game_refractor_hook()runs renders first, then passes each player'simage_urltonotify_tier_completion(), which passes it tobuild_tier_up_embed()viaset_image().Ordering change: renders now happen before notifications (previously the reverse) so the card art is available when the Discord embed fires. If the render fails or returns no
image_url, the notification sends without an image (graceful degradation).Team logo: not added — the
tier_updict fromevaluate-gamedoesn't include team data. Would need the API to return team info in tier_up objects.