Resolve ruff pre-commit hook vs pre-existing violations #108

New Issue

cal · 2026-03-23T04:36:11Z

cal commented

2026-03-23 04:36:11 +00:00

Summary

The ruff pre-commit hook (installed 2026-03-09) blocks commits touching any file with pre-existing violations. The codebase has hundreds of violations across core files (star imports, f-string in logger calls, quote style, unused variables).

Current workarounds:

PR #104 added a ruff.toml that globally suppresses rules conflicting with existing patterns (F403, F405, F841, E501, etc.)
Several PRs used --no-verify to bypass the hook entirely

Both are problematic:

Global F841 suppression undercuts the hook for the exact bug class that PRs #37/#38 were created to fix (unused variables / dead code)
--no-verify bypasses all hooks, not just ruff

Options

One-time formatting PR — Run ruff check --fix + ruff format across the whole codebase. Large diff but gets it done. The hook then works cleanly for all future commits.
Tighten ruff.toml with per-file-ignores — Keep suppressions but scope them to specific legacy files instead of globally. New files get the full rule set.
Move linting to CI only — Remove the pre-commit hook, add a Gitea Actions step that runs ruff on PRs. Developers aren't blocked locally, but violations are caught before merge.
Hybrid — Do option 1 (format everything), then option 3 (CI enforcement). Pre-commit hooks for formatting, CI for enforcement.

Recommendation

Option 1 + tightened ruff.toml. One big formatting commit clears the debt, then the hook works correctly going forward with minimal suppressions. The ruff.toml should only suppress rules that genuinely conflict with project patterns (e.g., star imports in __init__.py files), not blanket-suppress everything.

Files most affected

helpers/main.py — star imports, f-strings, unused vars
cogs/economy.py — star imports, quote style
in_game/gameplay_queries.py — bare excepts (now fixed in #104)
db_calls_gameplay.py — quote style, type annotations
command_logic/logic_gameplay.py — star imports

## Summary The ruff pre-commit hook (installed 2026-03-09) blocks commits touching any file with pre-existing violations. The codebase has hundreds of violations across core files (star imports, f-string in logger calls, quote style, unused variables). Current workarounds: - PR #104 added a `ruff.toml` that globally suppresses rules conflicting with existing patterns (F403, F405, F841, E501, etc.) - Several PRs used `--no-verify` to bypass the hook entirely Both are problematic: - Global `F841` suppression undercuts the hook for the exact bug class that PRs #37/#38 were created to fix (unused variables / dead code) - `--no-verify` bypasses all hooks, not just ruff ## Options 1. **One-time formatting PR** — Run `ruff check --fix` + `ruff format` across the whole codebase. Large diff but gets it done. The hook then works cleanly for all future commits. 2. **Tighten ruff.toml with per-file-ignores** — Keep suppressions but scope them to specific legacy files instead of globally. New files get the full rule set. 3. **Move linting to CI only** — Remove the pre-commit hook, add a Gitea Actions step that runs ruff on PRs. Developers aren't blocked locally, but violations are caught before merge. 4. **Hybrid** — Do option 1 (format everything), then option 3 (CI enforcement). Pre-commit hooks for formatting, CI for enforcement. ## Recommendation Option 1 + tightened `ruff.toml`. One big formatting commit clears the debt, then the hook works correctly going forward with minimal suppressions. The `ruff.toml` should only suppress rules that genuinely conflict with project patterns (e.g., star imports in `__init__.py` files), not blanket-suppress everything. ## Files most affected - `helpers/main.py` — star imports, f-strings, unused vars - `cogs/economy.py` — star imports, quote style - `in_game/gameplay_queries.py` — bare excepts (now fixed in #104) - `db_calls_gameplay.py` — quote style, type annotations - `command_logic/logic_gameplay.py` — star imports

Claude added the

ai-working

label 2026-03-23 06:31:17 +00:00

Claude added the

ai-working

label 2026-03-23 06:35:34 +00:00

cal referenced this issue from a commit

2026-03-23 06:37:33 +00:00

fix: tighten ruff.toml + add CI lint step (#108)

Claude referenced a pull request that will close this issue

2026-03-23 06:37:46 +00:00

fix: tighten ruff.toml + add CI lint step (#108) #109

Claude commented

2026-03-23 06:37:59 +00:00

PR #109 opened: #109

Approach taken (Option 2 + CI enforcement):

Tightened ruff.toml — Removed global F841/F401 suppression. Moved them to per-file-ignores scoped to legacy directories (cogs/**, in_game/**, helpers/**, etc.). New files outside these paths get full F841/F401 enforcement. Kept global ignores only for genuine project patterns: F403/F405 (star imports), E712 (SQLModel), F541 (1000+ legacy occurrences, deferred).
Fixed pre-commit hook violations — Audited all 26 existing violations (E711/E713/E721/E722/F811/F821 across 12 files) and added targeted per-file-ignores. ruff check . now returns zero violations — no more --no-verify needed.
Added .gitea/workflows/ruff-lint.yml — CI enforcement on every PR to main. Violations are caught before merge even if the hook is bypassed.

PR #109 opened: https://git.manticorum.com/cal/paper-dynasty-discord/pulls/109 **Approach taken (Option 2 + CI enforcement):** 1. **Tightened `ruff.toml`** — Removed global F841/F401 suppression. Moved them to `per-file-ignores` scoped to legacy directories (`cogs/**`, `in_game/**`, `helpers/**`, etc.). New files outside these paths get full F841/F401 enforcement. Kept global ignores only for genuine project patterns: F403/F405 (star imports), E712 (SQLModel), F541 (1000+ legacy occurrences, deferred). 2. **Fixed pre-commit hook violations** — Audited all 26 existing violations (E711/E713/E721/E722/F811/F821 across 12 files) and added targeted per-file-ignores. `ruff check .` now returns zero violations — no more `--no-verify` needed. 3. **Added `.gitea/workflows/ruff-lint.yml`** — CI enforcement on every PR to `main`. Violations are caught before merge even if the hook is bypassed.

Claude added

ai-pr-opened

and removed

ai-working

labels 2026-03-23 06:38:06 +00:00

cal closed this issue

2026-03-23 12:55:32 +00:00

cal referenced this issue from a commit

2026-03-23 12:55:34 +00:00

Merge pull request 'fix: tighten ruff.toml + add CI lint step (#108)' (#109) from ai/paper-dynasty-discord#108 into main

Sign in to join this conversation.