cal/paper-dynasty-discord
1
0
Fork 0
Code Issues 13 Pull Requests 8 Actions Packages Projects Releases Wiki Activity

fix: remove dead parameters from PR review feedback
All checks were successful
Ruff Lint / lint (pull_request) Successful in 13s
Details

Browse Source 
Remove unused `player_name` param from `_execute_refractor_test` and
unused `final` param from `update_embed` closure.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Cal Corum 2026-04-09 08:34:02 -05:00
parent 5b43f8dad3
commit f3a83f91fd
2 changed files with 6 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
cogs/dev_tools.py
View File

@ -226,7 +226,6 @@ class DevToolsCog(commands.Cog):
interaction=interaction,
embed=embed,
player_id=player_id,
player_name=player_name,
team_id=team_id,
card_type=card_type,
card_type_key=card_type_key,
@ -239,7 +238,6 @@ class DevToolsCog(commands.Cog):
interaction: discord.Interaction,
embed: discord.Embed,
player_id: int,
player_name: str,
team_id: int,
card_type: str,
card_type_key: str,
@ -259,9 +257,7 @@ class DevToolsCog(commands.Cog):
embed.remove_field(len(embed.fields) - 1)
# Helper to update the embed with current results
async def update_embed(
final: bool = False, view: discord.ui.View | None = None
):
async def update_embed(view: discord.ui.View | None = None):
results_text = "\n".join(results)
# Remove old results field if present, add new one
while len(embed.fields) > 1:
@ -299,9 +295,7 @@ class DevToolsCog(commands.Cog):
await update_embed()
except Exception as e:
results.append(f"❌ Play insertion failed: {e}")
await update_embed(
final=True, view=CleanupView(interaction.user.id, game_id, embed)
)
await update_embed(view=CleanupView(interaction.user.id, game_id, embed))
return
try:
@ -315,9 +309,7 @@ class DevToolsCog(commands.Cog):
await update_embed()
except Exception as e:
results.append(f"❌ Decision insertion failed: {e}")
await update_embed(
final=True, view=CleanupView(interaction.user.id, game_id, embed)
)
await update_embed(view=CleanupView(interaction.user.id, game_id, embed))
return
try:
@ -332,9 +324,7 @@ class DevToolsCog(commands.Cog):
except Exception as e:
results.append(f"❌ Season stats update failed: {e}")
results.append("⏭️ Skipped: evaluate-game (depends on season stats)")
await update_embed(
final=True, view=CleanupView(interaction.user.id, game_id, embed)
)
await update_embed(view=CleanupView(interaction.user.id, game_id, embed))
return
try:
@ -356,9 +346,7 @@ class DevToolsCog(commands.Cog):
await update_embed()
except Exception as e:
results.append(f"❌ Evaluate-game failed: {e}")
await update_embed(
final=True, view=CleanupView(interaction.user.id, game_id, embed)
)
await update_embed(view=CleanupView(interaction.user.id, game_id, embed))
return
# Step 6: Trigger card render (if tier-up)
@ -394,9 +382,7 @@ class DevToolsCog(commands.Cog):
results.append(f"⚠️ Card render failed (non-fatal): {e}")
# Final update with cleanup buttons
await update_embed(
final=True, view=CleanupView(interaction.user.id, game_id, embed)
)
await update_embed(view=CleanupView(interaction.user.id, game_id, embed))
async def setup(bot: commands.Bot):

3
tests/test_dev_tools.py
View File

@ -309,7 +309,6 @@ class TestRefractorTestExecute:
interaction=mock_interaction,
embed=base_embed,
player_id=100,
player_name="Mike Trout",
team_id=31,
card_type="batter",
card_type_key="batting",
@ -341,7 +340,6 @@ class TestRefractorTestExecute:
interaction=mock_interaction,
embed=base_embed,
player_id=100,
player_name="Mike Trout",
team_id=31,
card_type="batter",
card_type_key="batting",
@ -374,7 +372,6 @@ class TestRefractorTestExecute:
interaction=mock_interaction,
embed=base_embed,
player_id=100,
player_name="Mike Trout",
team_id=31,
card_type="batter",
card_type_key="batting",