feat: Track Catalog API endpoints (WP-06) (#71) #86

Claude · 2026-03-13T01:41:06Z

Claude commented

2026-03-13 01:41:06 +00:00

Closes #71

Summary

Adds GET /api/v2/evolution/tracks — list all tracks with optional card_type filter (batter|sp|rp); returns {"count": N, "items": [...]}
Adds GET /api/v2/evolution/tracks/{track_id} — single track with formula and t1–t4 threshold fields; returns 404 if not found
Both endpoints require Bearer token auth (401 if missing/invalid)
EvolutionTrack is lazy-imported inside each handler so the app can start before WP-01 merges into next-release

Files changed

app/routers_v2/evolution.py (new) — two GET endpoints
app/main.py — imports and registers the evolution router
tests/test_evolution_track_api.py (new) — 5 integration tests (auto-skip when POSTGRES_HOST not set)
pyproject.toml — suppresses pre-existing E402/F541 ruff warnings in app/main.py that were blocking the pre-commit hook

Test coverage

Test	What it checks
`test_list_tracks_returns_count_3`	All 3 tracks returned with correct `count`
`test_filter_by_card_type`	`?card_type=sp` returns exactly 1 track
`test_get_single_track_with_thresholds`	Track dict includes `formula` and all 4 threshold fields
`test_404_for_nonexistent_track`	Non-existent ID returns 404
`test_auth_required`	Both endpoints return 401 without a token

Integration tests require POSTGRES_HOST and assume WP-04 migration has run. They insert and clean up their own test data.

Notes

Depends on WP-01 (EvolutionTrack Peewee model in db_engine.py) and WP-04 (schema migration). Must merge after those PRs.
Lazy import pattern mirrors app/seed/evolution_tracks.py (PR #83).
pyproject.toml was not previously tracked in git; this PR adds it with the existing ruff config plus the new per-file ignore.

Closes #71 ## Summary - Adds `GET /api/v2/evolution/tracks` — list all tracks with optional `card_type` filter (`batter`|`sp`|`rp`); returns `{"count": N, "items": [...]}` - Adds `GET /api/v2/evolution/tracks/{track_id}` — single track with formula and t1–t4 threshold fields; returns 404 if not found - Both endpoints require Bearer token auth (401 if missing/invalid) - `EvolutionTrack` is lazy-imported inside each handler so the app can start before WP-01 merges into `next-release` ## Files changed - `app/routers_v2/evolution.py` (new) — two GET endpoints - `app/main.py` — imports and registers the evolution router - `tests/test_evolution_track_api.py` (new) — 5 integration tests (auto-skip when `POSTGRES_HOST` not set) - `pyproject.toml` — suppresses pre-existing `E402`/`F541` ruff warnings in `app/main.py` that were blocking the pre-commit hook ## Test coverage | Test | What it checks | |---|---| | `test_list_tracks_returns_count_3` | All 3 tracks returned with correct `count` | | `test_filter_by_card_type` | `?card_type=sp` returns exactly 1 track | | `test_get_single_track_with_thresholds` | Track dict includes `formula` and all 4 threshold fields | | `test_404_for_nonexistent_track` | Non-existent ID returns 404 | | `test_auth_required` | Both endpoints return 401 without a token | Integration tests require `POSTGRES_HOST` and assume WP-04 migration has run. They insert and clean up their own test data. ## Notes - **Depends on WP-01** (EvolutionTrack Peewee model in `db_engine.py`) and **WP-04** (schema migration). Must merge after those PRs. - Lazy import pattern mirrors `app/seed/evolution_tracks.py` (PR #83). - `pyproject.toml` was not previously tracked in git; this PR adds it with the existing ruff config plus the new per-file ignore.

Claude added 1 commit 2026-03-13 01:41:07 +00:00

feat: Track Catalog API endpoints (WP-06) (#71 ) ddf6ff5961

Closes #71

Adds GET /api/v2/evolution/tracks and GET /api/v2/evolution/tracks/{track_id}
endpoints for browsing evolution tracks and their thresholds.  Both endpoints
require Bearer token auth and return a track dict with formula and t1-t4
threshold fields.  The card_type query param filters the list endpoint.

EvolutionTrack is lazy-imported inside each handler so the app can start
before WP-01 (EvolutionTrack model) is merged into next-release.

Also suppresses pre-existing E402/F541 ruff warnings in app/main.py via
pyproject.toml per-file-ignores so the pre-commit hook does not block
unrelated future commits to that file.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Claude referenced this pull request

2026-03-13 01:41:25 +00:00

WP-06: Track Catalog API Endpoints #71

Claude added the

ai-reviewing

label 2026-03-13 01:45:47 +00:00

Claude commented

2026-03-13 01:47:34 +00:00

AI Code Review

Files Reviewed

app/routers_v2/evolution.py (added)
app/main.py (modified — 2 lines)
tests/test_evolution_track_api.py (added)
pyproject.toml (added)

Findings

Correctness

from ..db_engine import model_to_dict works correctly — model_to_dict is imported at module level in db_engine.py via from playhouse.shortcuts import model_to_dict, making it a module-level name accessible from other modules.
list_tracks: Peewee queryset iterated once into a Python list before len() — no double-iteration hazard.
get_track: EvolutionTrack.get_by_id(track_id) raises DoesNotExist on miss; the broad except Exception catches it and returns 404 correctly. Mild concern: a DB connection failure would also return 404 rather than 500. Acceptable given the codebase pattern, but worth knowing.
card_type filter is case-sensitive — ?card_type=Batter returns empty, not the batter track. This is fine given the API spec says lowercase values, but worth documenting.
track_id: int type annotation causes FastAPI to return 422 (not 404) for non-integer paths — correct behaviour.

Security

logging.warning("Bad Token: [REDACTED]") — correct [REDACTED] pattern used in both handlers. No token exposure.
card_type passed through Peewee's .where() — parameterized, no SQL injection risk.
Auth enforced on both endpoints via oauth2_scheme + valid_token — consistent with all other routers.
No hardcoded credentials.

Style & Conventions

Lazy import pattern (from ..db_engine import EvolutionTrack inside each handler) correctly mirrors app/seed/evolution_tracks.py. Clean.
Import order (APIRouter, Depends, HTTPException, Query — all from fastapi) and auth pattern match codebase conventions exactly.
pyproject.toml suppression rationale is well-commented. E402 and F541 suppressions are accurate for the pre-existing issues in main.py (logging setup before imports; bare f-string in version=f"0.1.1" at line 117).

Suggestions

except Exception in get_track could be narrowed to except EvolutionTrack.DoesNotExist since EvolutionTrack is already in scope at that point. This would let DB connection errors surface as 500 rather than silently converting to 404. Not a blocker.
test_list_tracks_returns_count_3 asserts count == 3 (exact count). The docstring correctly notes no other test modules insert evolution_track rows — this assumption holds as long as other evolution test files from future WPs also clean up. Low risk.

Verdict: APPROVED

Clean, focused diff — 2 new files, 2 lines added to main.py, and a ruff config. Auth, logging, and query patterns match the rest of the codebase exactly. No security regressions, no scope creep. Integration tests cover list, filter, single-fetch, 404, and auth. Good to merge after WP-01 and WP-04 land.

Automated review by Claude PR Reviewer

## AI Code Review ### Files Reviewed - `app/routers_v2/evolution.py` (added) - `app/main.py` (modified — 2 lines) - `tests/test_evolution_track_api.py` (added) - `pyproject.toml` (added) ### Findings #### Correctness - `from ..db_engine import model_to_dict` works correctly — `model_to_dict` is imported at module level in `db_engine.py` via `from playhouse.shortcuts import model_to_dict`, making it a module-level name accessible from other modules. - `list_tracks`: Peewee queryset iterated once into a Python list before `len()` — no double-iteration hazard. - `get_track`: `EvolutionTrack.get_by_id(track_id)` raises `DoesNotExist` on miss; the broad `except Exception` catches it and returns 404 correctly. Mild concern: a DB connection failure would also return 404 rather than 500. Acceptable given the codebase pattern, but worth knowing. - `card_type` filter is case-sensitive — `?card_type=Batter` returns empty, not the batter track. This is fine given the API spec says lowercase values, but worth documenting. - `track_id: int` type annotation causes FastAPI to return 422 (not 404) for non-integer paths — correct behaviour. #### Security - `logging.warning("Bad Token: [REDACTED]")` — correct `[REDACTED]` pattern used in both handlers. No token exposure. - `card_type` passed through Peewee's `.where()` — parameterized, no SQL injection risk. - Auth enforced on both endpoints via `oauth2_scheme` + `valid_token` — consistent with all other routers. - No hardcoded credentials. #### Style & Conventions - Lazy import pattern (`from ..db_engine import EvolutionTrack` inside each handler) correctly mirrors `app/seed/evolution_tracks.py`. Clean. - Import order (`APIRouter`, `Depends`, `HTTPException`, `Query` — all from `fastapi`) and auth pattern match codebase conventions exactly. - `pyproject.toml` suppression rationale is well-commented. `E402` and `F541` suppressions are accurate for the pre-existing issues in `main.py` (logging setup before imports; bare f-string in `version=f"0.1.1"` at line 117). #### Suggestions - `except Exception` in `get_track` could be narrowed to `except EvolutionTrack.DoesNotExist` since `EvolutionTrack` is already in scope at that point. This would let DB connection errors surface as 500 rather than silently converting to 404. Not a blocker. - `test_list_tracks_returns_count_3` asserts `count == 3` (exact count). The docstring correctly notes no other test modules insert evolution_track rows — this assumption holds as long as other evolution test files from future WPs also clean up. Low risk. ### Verdict: APPROVED Clean, focused diff — 2 new files, 2 lines added to main.py, and a ruff config. Auth, logging, and query patterns match the rest of the codebase exactly. No security regressions, no scope creep. Integration tests cover list, filter, single-fetch, 404, and auth. Good to merge after WP-01 and WP-04 land. --- *Automated review by Claude PR Reviewer*

Claude added

ai-reviewed

and removed

ai-reviewing

labels 2026-03-13 01:48:06 +00:00

cal merged commit 32ca21558e into next-release

2026-03-16 16:15:03 +00:00

cal deleted branch ai/paper-dynasty-database#71

2026-03-16 16:15:04 +00:00

cal referenced this issue from a commit

2026-03-16 16:15:06 +00:00

Merge pull request 'feat: Track Catalog API endpoints (WP-06) (#71)' (#86) from ai/paper-dynasty-database#71 into next-release

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-database#86