WP-12: Tier Badge on Card Embed #77

New Issue

cal · 2026-03-12T20:56:47Z

cal commented

2026-03-12 20:56:47 +00:00

Description

Modify get_card_embeds() in the bot to show a tier badge prefix in the card title when a card has evolution progress. E.g. [T2] Mike Trout, [EVO] Mike Trout for T4.

Repo: discord-app (code in bot repo, tracked here for milestone)
Phase: 1c (Bot Integration)
Dependencies: WP-07
Complexity: S

Implementation

evo_state = await db_get(f"evolution/cards/{card['id']}")  # may 404
tier_badge = ""
if evo_state and evo_state.get("current_tier", 0) > 0:
    tier = evo_state["current_tier"]
    tier_badge = f"[{'EVO' if tier >= 4 else f'T{tier}'}] "

Must be wrapped in try/except — API failure must NOT break card display.

Tests (write first in `discord-app/tests/test_card_embed_evolution.py`)

Unit: tier badge format (T0=none, T1=[T1], T4=[EVO])
Unit: badge in title
Unit: fully evolved badge
Unit: no evolution state → no badge (graceful fallback)
Unit: embed color unchanged (still from rarity)

Plan reference: docs/prd-evolution/PHASE1_PROJECT_PLAN.md WP-12

## Description Modify `get_card_embeds()` in the bot to show a tier badge prefix in the card title when a card has evolution progress. E.g. `[T2] Mike Trout`, `[EVO] Mike Trout` for T4. **Repo:** `discord-app` (code in bot repo, tracked here for milestone) **Phase:** 1c (Bot Integration) **Dependencies:** WP-07 **Complexity:** S ## Implementation ```python evo_state = await db_get(f"evolution/cards/{card['id']}") # may 404 tier_badge = "" if evo_state and evo_state.get("current_tier", 0) > 0: tier = evo_state["current_tier"] tier_badge = f"[{'EVO' if tier >= 4 else f'T{tier}'}] " ``` Must be wrapped in try/except — API failure must NOT break card display. ## Tests (write first in `discord-app/tests/test_card_embed_evolution.py`) - [ ] Unit: tier badge format (T0=none, T1=[T1], T4=[EVO]) - [ ] Unit: badge in title - [ ] Unit: fully evolved badge - [ ] Unit: no evolution state → no badge (graceful fallback) - [ ] Unit: embed color unchanged (still from rarity) **Plan reference:** `docs/prd-evolution/PHASE1_PROJECT_PLAN.md` WP-12

cal added this to the Card Evolution Phase 1 milestone 2026-03-12 20:59:15 +00:00

cal added the

evolution

phase-1c

labels 2026-03-12 20:59:26 +00:00

cal referenced this issue

2026-03-12 20:59:51 +00:00

Card Evolution Phase 1 — Master Tracker #81

Claude added the

ai-working

label 2026-03-13 20:01:44 +00:00

Claude referenced a pull request from cal/paper-dynasty-discord that will close this issue

2026-03-13 20:07:55 +00:00

feat: Refractor tier badge prefix in card embed title (WP-12) (#77) #88

Claude added

ai-pr-opened

and removed

ai-working

labels 2026-03-13 20:08:06 +00:00

Claude commented

2026-03-13 20:08:12 +00:00

PR opened in the discord-app repo: cal/paper-dynasty-discord#88

Approach: Added 9 lines to get_card_embeds() in helpers/main.py — fetches evolution/cards/{card_id}, computes the badge string ([T1]–[T3] or [EVO]), and prepends it to the embed title. The whole fetch is in try/except Exception: pass so any API failure is silent.

Also added ruff.toml to suppress legacy star-import/bare-except rules that were blocking the pre-commit hook (hook was installed after helpers/main.py last committed).

11 unit tests in tests/test_card_embed_evolution.py cover all specified scenarios.

PR opened in the discord-app repo: https://git.manticorum.com/cal/paper-dynasty-discord/pulls/88 **Approach:** Added 9 lines to `get_card_embeds()` in `helpers/main.py` — fetches `evolution/cards/{card_id}`, computes the badge string (`[T1]`–`[T3]` or `[EVO]`), and prepends it to the embed title. The whole fetch is in `try/except Exception: pass` so any API failure is silent. Also added `ruff.toml` to suppress legacy star-import/bare-except rules that were blocking the pre-commit hook (hook was installed after `helpers/main.py` last committed). 11 unit tests in `tests/test_card_embed_evolution.py` cover all specified scenarios.

cal referenced a pull request from cal/paper-dynasty-discord that will close this issue

2026-03-18 20:41:17 +00:00

feat(WP-12): tier badge on card embed (#77) #91

cal closed this issue

2026-03-18 21:20:41 +00:00

Sign in to join this conversation.

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-database#77

WP-12: Tier Badge on Card Embed #77

Description

Implementation

Tests (write first in discord-app/tests/test_card_embed_evolution.py)

Tests (write first in `discord-app/tests/test_card_embed_evolution.py`)