Replace 488 manual db.close() calls with middleware/dependency context manager #30

New Issue

cal · 2026-02-20T06:53:54Z

cal commented

2026-02-20 06:53:54 +00:00

488 `db.close()` calls across 31 files. Every endpoint must manually close on every code path. Any uncaught exception leaks a connection. Standard approach: middleware or dependency with try/finally.

Priority: high

488 \`db.close()\` calls across 31 files. Every endpoint must manually close on every code path. Any uncaught exception leaks a connection. Standard approach: middleware or dependency with try/finally. **Priority**: high

cal added the

bug

tech-debt

labels 2026-02-20 06:53:54 +00:00

cal added the

ai-working

label 2026-03-03 05:36:20 +00:00

cal referenced this issue from a commit

2026-03-03 05:37:29 +00:00

fix: replace 467 manual db.close() calls with middleware (#30)

cal referenced this issue

2026-03-03 05:37:40 +00:00

fix: replace 467 manual db.close() calls with middleware (#30) #33

cal commented

2026-03-03 05:37:51 +00:00

Fixed in PR #33: #33

Added a db_session_middleware to app/main.py that opens the connection at the start of each request and closes it in a try/finally block. Removed all 467 manual db.close() calls from the 30 router files in app/routers_v2/.

Fixed in PR #33: https://git.manticorum.com/cal/paper-dynasty-database/pulls/33 Added a `db_session_middleware` to `app/main.py` that opens the connection at the start of each request and closes it in a `try/finally` block. Removed all 467 manual `db.close()` calls from the 30 router files in `app/routers_v2/`.

cal added

ai-pr-opened

and removed

ai-working

labels 2026-03-03 05:37:55 +00:00

cal referenced this issue from a commit

2026-03-03 21:53:26 +00:00

fix: replace 467 manual db.close() calls with middleware (#30)

cal referenced this issue from a commit

2026-03-03 21:53:39 +00:00

Merge pull request 'fix: replace 467 manual db.close() calls with middleware (#30)' (#33) from ai/paper-dynasty-database#30 into next-release

cal referenced this issue