cal/paper-dynasty-database
1
0
Fork 0
Code Issues 7 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Remove or fix dead CSV code in v1_cards_get_one referencing removed roster fields #25

New Issue
Closed
opened 2026-02-20 06:53:26 +00:00 by cal · 1 comment
cal commented 2026-02-20 06:53:26 +00:00
Owner
Copy Link

`app/routers_v2/cards.py:144-148`. CSV branch accesses `this_card.roster1.name`, `.roster2.name`, `.roster3.name` — Card model has no such fields. Will raise AttributeError at runtime.

Priority: high

\`app/routers_v2/cards.py:144-148\`. CSV branch accesses \`this_card.roster1.name\`, \`.roster2.name\`, \`.roster3.name\` — Card model has no such fields. Will raise AttributeError at runtime. **Priority**: high
cal added the
bug
 label 2026-02-20 06:53:26 +00:00
cal added the
ai-working
 label 2026-03-03 18:05:25 +00:00
cal removed the
ai-working
 label 2026-03-03 18:06:43 +00:00
cal commented 2026-03-03 18:06:47 +00:00
Author
Owner
Copy Link

Fixed in PR #35: #35

Removed roster1, roster2, roster3 from the CSV header and data row in v1_cards_get_one. The Card model has no such fields — they were remnants of a previous schema. The CSV now reflects only the actual model fields: id, player, team, pack, value.

Fixed in PR #35: https://git.manticorum.com/cal/paper-dynasty-database/pulls/35 Removed `roster1`, `roster2`, `roster3` from the CSV header and data row in `v1_cards_get_one`. The `Card` model has no such fields — they were remnants of a previous schema. The CSV now reflects only the actual model fields: `id`, `player`, `team`, `pack`, `value`.
cal added the
ai-pr-opened
 label 2026-03-03 18:06:51 +00:00
cal closed this issue 2026-03-10 18:26:27 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ai-changes-requested

   
ai-failed

   
ai-merged

PR merged by AI ops agent

  
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-reviewing

   
ai-working

   
bug

   
enhancement

   
evolution

Card Evolution system

  
performance

   
phase-0

Render Pipeline Optimization

  
phase-1a

Schema & Data Foundation

  
phase-1b

API & Formula Engine

  
phase-1c

Bot Integration

  
phase-1d

Deployment

  
security

   
tech-debt

   
todo
No Label
ai-changes-requested
ai-failed
ai-merged
ai-pr-opened
ai-reviewed
ai-reviewing
ai-reviewing
ai-working
bug
enhancement
evolution
performance
phase-0
phase-1a
phase-1b
phase-1c
phase-1d
security
tech-debt
todo
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-database#25
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?