Move random.randint default out of Pydantic model field #24

New Issue

cal · 2026-02-20T06:53:19Z

cal commented

2026-02-20 06:53:19 +00:00

`app/routers_v2/mlbplayers.py:40` — `offense_col: int = random.randint(1, 3)`. Pydantic evaluates field defaults at class definition time, not request time. Every MLB player gets the same random value. Use `Field(default_factory=lambda: random.randint(1, 3))`.

Priority: medium

\`app/routers_v2/mlbplayers.py:40\` — \`offense_col: int = random.randint(1, 3)\`. Pydantic evaluates field defaults at class definition time, not request time. Every MLB player gets the same random value. Use \`Field(default_factory=lambda: random.randint(1, 3))\`. **Priority**: medium

cal added the

bug

label 2026-02-20 06:53:19 +00:00

cal added the

ai-working

label 2026-03-03 20:05:07 +00:00

cal referenced this issue from a commit

2026-03-03 20:05:27 +00:00

fix: use Field(default_factory) for offense_col random default (#24)

cal referenced a pull request that will close this issue

2026-03-03 20:05:39 +00:00

fix: use Field(default_factory) for offense_col random default (#24) #38

cal added the

ai-pr-opened

label 2026-03-03 20:05:45 +00:00

cal commented

2026-03-03 20:05:55 +00:00

Fixed in PR #38: #38

Changed offense_col: int = random.randint(1, 3) to offense_col: int = pydantic.Field(default_factory=lambda: random.randint(1, 3)) in app/routers_v2/mlbplayers.py. The bare default was evaluated once at class definition time — every instance shared the same value for the process lifetime. The default_factory ensures a fresh random value per instantiation.

Fixed in PR #38: https://git.manticorum.com/cal/paper-dynasty-database/pulls/38 Changed `offense_col: int = random.randint(1, 3)` to `offense_col: int = pydantic.Field(default_factory=lambda: random.randint(1, 3))` in `app/routers_v2/mlbplayers.py`. The bare default was evaluated once at class definition time — every instance shared the same value for the process lifetime. The `default_factory` ensures a fresh random value per instantiation.

cal removed the

ai-working

label 2026-03-03 20:06:28 +00:00

cal referenced this issue from a commit

2026-03-03 21:46:06 +00:00

fix: use Field(default_factory) for offense_col random default (#24)

cal closed this issue

2026-03-03 21:46:47 +00:00

cal referenced this issue from a commit

2026-03-03 21:46:49 +00:00

Merge pull request 'fix: use Field(default_factory) for offense_col random default (#24)' (#38) from ai/paper-dynasty-database-24 into next-release

cal referenced this issue