feat: include animated_url in tier-up response for T3/T4 #201
Labels
No Label
ai-changes-requested
ai-failed
ai-merged
ai-pr-opened
ai-reviewed
ai-reviewing
ai-working
autonomous
bug
enhancement
evolution
performance
phase-0
phase-1a
phase-1b
phase-1c
phase-1d
security
size:M
size:S
tech-debt
todo
type:feature
type:stability
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cal/paper-dynasty-database#201
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
When a tier-up to T3 or T4 occurs, the
evaluate-gameendpoint returnsvariant_createdin the tier_ups list. The Discord bot uses this to show a notification, but there is noanimated_urlfield in the response.The bot would need to separately construct or call the
/animatedendpoint to get an APNG URL for the notification embed.Fix
Add an
animated_urlfield to the tier-up response for T3/T4 tier-ups. This could be a pre-constructed URL to the animated endpoint, or an S3 URL if database#198 (APNG S3 pipeline) is implemented.Relationship
Companion to discord#144 (tier-up notification should include card image). That issue covers the bot-side embed; this covers the API-side data.
PR #208 opened: #208
Added
animated_urlto T3/T4 tier-up entries inevaluate-game. The URL is constructed fromAPI_BASE_URLenv var +/api/v2/players/{player_id}/{card_type}card/{date}/{variant}/animated. SetAPI_BASE_URL=https://pd.manticorum.com:815in the container env to get absolute URLs for Discord embeds. T0–T2 tier-ups are unaffected.