bug: variant filter commented out on cards list endpoint #197
Labels
No Label
ai-changes-requested
ai-failed
ai-merged
ai-pr-opened
ai-reviewed
ai-reviewing
ai-reviewing
ai-working
bug
enhancement
evolution
performance
phase-0
phase-1a
phase-1b
phase-1c
phase-1d
security
tech-debt
todo
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cal/paper-dynasty-database#197
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
In
app/routers_v2/cards.pylines 82–83, the variant filter on the cards list endpoint is commented out. The CSV output also omits variant (line 118).This means
GET /api/v2/cards?team_id=Xreturns both base cards and refractor variant cards with no way to distinguish them. Consumers cannot filter or identify which rows are boosted variants.Fix
Uncomment the variant filter so callers can pass
?variant=0to get base cards only, or?variant=Nto get a specific variant. Ensure the CSV export includes the variant column.Impact
Any consumer listing cards (bot collection views, web app, admin tools) will mix base and variant cards without the ability to separate them. This becomes a real problem once refractor cards are live in prod.