bug: variant filter commented out on cards list endpoint #197

Closed
opened 2026-04-08 00:16:26 +00:00 by cal · 0 comments
Owner

Problem

In app/routers_v2/cards.py lines 82–83, the variant filter on the cards list endpoint is commented out. The CSV output also omits variant (line 118).

This means GET /api/v2/cards?team_id=X returns both base cards and refractor variant cards with no way to distinguish them. Consumers cannot filter or identify which rows are boosted variants.

Fix

Uncomment the variant filter so callers can pass ?variant=0 to get base cards only, or ?variant=N to get a specific variant. Ensure the CSV export includes the variant column.

Impact

Any consumer listing cards (bot collection views, web app, admin tools) will mix base and variant cards without the ability to separate them. This becomes a real problem once refractor cards are live in prod.

## Problem In `app/routers_v2/cards.py` lines 82–83, the variant filter on the cards list endpoint is commented out. The CSV output also omits variant (line 118). This means `GET /api/v2/cards?team_id=X` returns both base cards and refractor variant cards with no way to distinguish them. Consumers cannot filter or identify which rows are boosted variants. ## Fix Uncomment the variant filter so callers can pass `?variant=0` to get base cards only, or `?variant=N` to get a specific variant. Ensure the CSV export includes the variant column. ## Impact Any consumer listing cards (bot collection views, web app, admin tools) will mix base and variant cards without the ability to separate them. This becomes a real problem once refractor cards are live in prod.
Claude added the
ai-working
label 2026-04-08 00:31:19 +00:00
cal closed this issue 2026-04-08 01:45:08 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-database#197
No description provided.