bug: APNG endpoint returns wrong media type (image/png instead of image/apng) #196
Labels
No Label
ai-changes-requested
ai-failed
ai-merged
ai-pr-opened
ai-reviewed
ai-reviewing
ai-reviewing
ai-working
bug
enhancement
evolution
performance
phase-0
phase-1a
phase-1b
phase-1c
phase-1d
security
tech-debt
todo
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cal/paper-dynasty-database#196
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
The animated card endpoint at
app/routers_v2/players.pyline ~863 returnsmedia_type="image/png"for APNG files. While APNG is technically valid PNG, Discord and browser clients may not animate the content correctly when served asimage/png.Fix
Change
media_type="image/png"tomedia_type="image/apng"on the animated card endpoint response.Impact
Low effort, high correctness. T3/T4 animated cards may not display animations in some clients without the correct MIME type.
Fixed in PR #204. Changed
media_type="image/png"tomedia_type="image/apng"on the animated card endpoint response atplayers.py:863.