cal/paper-dynasty-database
1
0
Fork 0
Code Issues 7 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Batch BattingCard/BattingCardRatings lookups in lineup endpoints #18

New Issue
Closed
opened 2026-02-20 06:52:43 +00:00 by cal · 1 comment
cal commented 2026-02-20 06:52:43 +00:00
Owner
Copy Link

`app/routers_v2/teams.py` — `get_bratings` helper (line 373) and `get_scouting_dfs` each call `get_or_none` for every individual player during lineup construction.

Priority: medium

\`app/routers_v2/teams.py\` — \`get_bratings\` helper (line 373) and \`get_scouting_dfs\` each call \`get_or_none\` for every individual player during lineup construction. **Priority**: medium
cal added the
performance
 label 2026-02-20 06:52:43 +00:00
cal added the
ai-working
 label 2026-03-03 23:31:16 +00:00
cal removed the
ai-working
 label 2026-03-03 23:34:44 +00:00
cal commented 2026-03-03 23:34:47 +00:00
Author
Owner
Copy Link

Fixed in PR #45.

Replaced the per-player get_or_none() calls inside get_bratings() with two bulk SELECT queries executed once before the position loop — one for BattingCard, one for BattingCardRatings. Both are stored in dicts keyed by player_id / card+hand, reducing DB round trips from O(3N) to O(2) per lineup build.

Fixed in PR #45. Replaced the per-player `get_or_none()` calls inside `get_bratings()` with two bulk SELECT queries executed once before the position loop — one for `BattingCard`, one for `BattingCardRatings`. Both are stored in dicts keyed by player_id / card+hand, reducing DB round trips from O(3N) to O(2) per lineup build.
cal added the
ai-pr-opened
 label 2026-03-03 23:34:53 +00:00
cal closed this issue 2026-03-07 03:16:14 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ai-changes-requested

   
ai-failed

   
ai-merged

PR merged by AI ops agent

  
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-reviewing

   
ai-working

   
bug

   
enhancement

   
evolution

Card Evolution system

  
performance

   
phase-0

Render Pipeline Optimization

  
phase-1a

Schema & Data Foundation

  
phase-1b

API & Formula Engine

  
phase-1c

Bot Integration

  
phase-1d

Deployment

  
security

   
tech-debt

   
todo
No Label
ai-changes-requested
ai-failed
ai-merged
ai-pr-opened
ai-reviewed
ai-reviewing
ai-reviewing
ai-working
bug
enhancement
evolution
performance
phase-0
phase-1a
phase-1b
phase-1c
phase-1d
security
tech-debt
todo
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-database#18
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?