cal/paper-dynasty-database
1
0
Fork 0
Code Issues 7 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

feat: add limit/pagination to pitchingcardratings endpoint #136

New Issue
Closed
opened 2026-03-24 03:39:53 +00:00 by cal · 1 comment
cal commented 2026-03-24 03:39:53 +00:00
Owner
Copy Link

The GET /api/v2/pitchingcardratings endpoint returns all records with no limit parameter. Add an optional limit: int query param (default 100, max 500).

Found during smoke test development — endpoints without limits cause timeouts and excessive data transfer.

The `GET /api/v2/pitchingcardratings` endpoint returns all records with no `limit` parameter. Add an optional `limit: int` query param (default 100, max 500). Found during smoke test development — endpoints without limits cause timeouts and excessive data transfer.
Claude added the
ai-working
 label 2026-03-24 09:01:06 +00:00
Claude added
ai-pr-opened
 and removed
ai-working
 labels 2026-03-24 09:03:16 +00:00
Claude commented 2026-03-24 09:03:19 +00:00
Collaborator
Copy Link

PR opened: #161

Added limit: int = 100 parameter to GET /api/v2/pitchingcardratings, capped at 500 via max(0, min(limit, 500)). Applied after all filters (pitchingcard_id, vs_hand, cardset_id) and before the CSV/JSON branch so both paths honour the limit.

PR opened: https://git.manticorum.com/cal/paper-dynasty-database/pulls/161 Added `limit: int = 100` parameter to `GET /api/v2/pitchingcardratings`, capped at 500 via `max(0, min(limit, 500))`. Applied after all filters (pitchingcard_id, vs_hand, cardset_id) and before the CSV/JSON branch so both paths honour the limit.
cal closed this issue 2026-03-24 12:08:45 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ai-changes-requested

   
ai-failed

   
ai-merged

PR merged by AI ops agent

  
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-reviewing

   
ai-working

   
bug

   
enhancement

   
evolution

Card Evolution system

  
performance

   
phase-0

Render Pipeline Optimization

  
phase-1a

Schema & Data Foundation

  
phase-1b

API & Formula Engine

  
phase-1c

Bot Integration

  
phase-1d

Deployment

  
security

   
tech-debt

   
todo
No Label
ai-changes-requested
ai-failed
ai-merged
ai-pr-opened
ai-reviewed
ai-reviewing
ai-reviewing
ai-working
bug
enhancement
evolution
performance
phase-0
phase-1a
phase-1b
phase-1c
phase-1d
security
tech-debt
todo
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-database#136
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?