cal/paper-dynasty-database
1
0
Fork 0
Code Issues 7 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Guard against None rating objects in pitcher sorting functions #13

New Issue
Closed
opened 2026-02-20 06:52:17 +00:00 by cal · 1 comment
cal commented 2026-02-20 06:52:17 +00:00
Owner
Copy Link

`app/routers_v2/teams.py:600-615` and `679-694`. `get_total_ops` calls `vlval.obp` directly after `get_or_none()`. If rating row doesn't exist, AttributeError produces a 500 response. DH-finding path correctly catches this but pitcher paths don't.

Priority: high

\`app/routers_v2/teams.py:600-615\` and \`679-694\`. \`get_total_ops\` calls \`vlval.obp\` directly after \`get_or_none()\`. If rating row doesn't exist, AttributeError produces a 500 response. DH-finding path correctly catches this but pitcher paths don't. **Priority**: high
cal added the
bug
 label 2026-02-20 06:52:17 +00:00
cal added the
ai-working
 label 2026-03-04 02:01:13 +00:00
cal removed the
ai-working
 label 2026-03-04 02:04:23 +00:00
cal commented 2026-03-04 02:04:27 +00:00
Author
Owner
Copy Link

Fixed in PR #50: #50

Added None checks for vlval/vrval in both get_total_ops closures (sort_pitchers and the inner sort_starters). When either rating row is missing, the function returns float("inf") so the pitcher sorts to the end of the list rather than raising an AttributeError and producing a 500 response.

Fixed in PR #50: https://git.manticorum.com/cal/paper-dynasty-database/pulls/50 Added `None` checks for `vlval`/`vrval` in both `get_total_ops` closures (`sort_pitchers` and the inner `sort_starters`). When either rating row is missing, the function returns `float("inf")` so the pitcher sorts to the end of the list rather than raising an `AttributeError` and producing a 500 response.
cal added the
ai-pr-opened
 label 2026-03-04 02:04:33 +00:00
cal closed this issue 2026-03-05 03:29:49 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ai-changes-requested

   
ai-failed

   
ai-merged

PR merged by AI ops agent

  
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-reviewing

   
ai-working

   
bug

   
enhancement

   
evolution

Card Evolution system

  
performance

   
phase-0

Render Pipeline Optimization

  
phase-1a

Schema & Data Foundation

  
phase-1b

API & Formula Engine

  
phase-1c

Bot Integration

  
phase-1d

Deployment

  
security

   
tech-debt

   
todo
No Label
ai-changes-requested
ai-failed
ai-merged
ai-pr-opened
ai-reviewed
ai-reviewing
ai-reviewing
ai-working
bug
enhancement
evolution
performance
phase-0
phase-1a
phase-1b
phase-1c
phase-1d
security
tech-debt
todo
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-database#13
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?