cal/paper-dynasty-database
1
0
Fork 0
Code Issues 7 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Fix get_one_player CSV response — data row never written to output #12

New Issue
Closed
opened 2026-02-20 06:52:11 +00:00 by cal · 1 comment
cal commented 2026-02-20 06:52:11 +00:00
Owner
Copy Link

`app/routers_v2/players.py:608-664`. `return_val` assigned from `DataFrame(data_list).to_csv()` on line 635, then actual player data row appended to `data_list` on line 636 — after CSV was already computed. CSV always contains only header row.

Priority: high

\`app/routers_v2/players.py:608-664\`. \`return_val\` assigned from \`DataFrame(data_list).to_csv()\` on line 635, then actual player data row appended to \`data_list\` on line 636 — after CSV was already computed. CSV always contains only header row. **Priority**: high
cal added the
bug
 label 2026-02-20 06:52:11 +00:00
cal added the
ai-working
 label 2026-03-04 02:30:51 +00:00
cal commented 2026-03-04 02:32:11 +00:00
Author
Owner
Copy Link

Fixed in PR #51.

Root cause: DataFrame(data_list).to_csv() was called before data_list.append(player_row), so the CSV always contained only the header row.

Fix: Moved the to_csv() call to after the append() — a single-line swap with no other changes.

Fixed in PR #51. **Root cause:** `DataFrame(data_list).to_csv()` was called before `data_list.append(player_row)`, so the CSV always contained only the header row. **Fix:** Moved the `to_csv()` call to after the `append()` — a single-line swap with no other changes.
cal added
ai-pr-opened
 and removed
ai-working
 labels 2026-03-04 02:32:34 +00:00
cal closed this issue 2026-03-10 18:26:23 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ai-changes-requested

   
ai-failed

   
ai-merged

PR merged by AI ops agent

  
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-reviewing

   
ai-working

   
bug

   
enhancement

   
evolution

Card Evolution system

  
performance

   
phase-0

Render Pipeline Optimization

  
phase-1a

Schema & Data Foundation

  
phase-1b

API & Formula Engine

  
phase-1c

Bot Integration

  
phase-1d

Deployment

  
security

   
tech-debt

   
todo
No Label
ai-changes-requested
ai-failed
ai-merged
ai-pr-opened
ai-reviewed
ai-reviewing
ai-reviewing
ai-working
bug
enhancement
evolution
performance
phase-0
phase-1a
phase-1b
phase-1c
phase-1d
security
tech-debt
todo
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-database#12
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?