fix: season-stats update-game leaks SQL in 500 error for nonexistent game #113

New Issue

cal · 2026-03-19T16:32:40Z

cal commented

2026-03-19 16:32:40 +00:00

Description

POST /api/v2/season-stats/update-game/{game_id} with a nonexistent game_id returns a 500 with the raw Peewee SQL query and params in the error detail:

{"detail":"Season stats update failed for game 999999: <Model: StratGame> instance matching query does not exist:\nSQL: SELECT ... FROM \"stratgame\" ...\nParams: [999999, 1, 0]"}

Expected

Should catch StratGame.DoesNotExist and return a clean 404:

{"detail": "Game 999999 not found"}

Location

app/routers_v2/season_stats.py — the except Exception block on line 50 re-raises as 500 with str(exc), which includes the SQL. Either catch DoesNotExist specifically before the generic handler, or sanitize the message.

Found during

Phase 1 smoke testing (2026-03-19)

## Description `POST /api/v2/season-stats/update-game/{game_id}` with a nonexistent game_id returns a 500 with the raw Peewee SQL query and params in the error detail: ```json {"detail":"Season stats update failed for game 999999: <Model: StratGame> instance matching query does not exist:\nSQL: SELECT ... FROM \"stratgame\" ...\nParams: [999999, 1, 0]"} ``` ## Expected Should catch `StratGame.DoesNotExist` and return a clean 404: ```json {"detail": "Game 999999 not found"} ``` ## Location `app/routers_v2/season_stats.py` — the `except Exception` block on line 50 re-raises as 500 with `str(exc)`, which includes the SQL. Either catch `DoesNotExist` specifically before the generic handler, or sanitize the message. ## Found during Phase 1 smoke testing (2026-03-19)

Claude added the

ai-working

label 2026-03-19 17:01:07 +00:00

cal referenced this issue from a commit

2026-03-19 17:01:53 +00:00

fix: catch DoesNotExist and return 404 for nonexistent game_id

Claude referenced a pull request that will close this issue

2026-03-19 17:02:00 +00:00

fix: season-stats update-game returns 404 for nonexistent game_id #117

Claude added

ai-pr-opened

and removed