cal/paper-dynasty-database
1
0
Fork 0
Code Issues 7 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Complete or remove the stub live_update_batting endpoint #10

New Issue
Closed
opened 2026-02-20 06:52:01 +00:00 by cal · 1 comment
cal commented 2026-02-20 06:52:01 +00:00
Owner
Copy Link

`app/routers_v2/scouting.py:57-89`. Iterates over `files.vl_basic` (a string, not parsed CSV), has `pass` with TODO comments. The loop iterates over characters in a filename string. Endpoint is completely broken.

Priority: high

\`app/routers_v2/scouting.py:57-89\`. Iterates over \`files.vl_basic\` (a string, not parsed CSV), has \`pass\` with TODO comments. The loop iterates over characters in a filename string. Endpoint is completely broken. **Priority**: high
cal added the
bug
todo
 labels 2026-02-20 06:52:01 +00:00
cal added the
ai-working
 label 2026-03-04 04:31:10 +00:00
cal removed the
ai-working
 label 2026-03-04 04:32:54 +00:00
cal commented 2026-03-04 04:32:59 +00:00
Author
Owner
Copy Link

PR #54 opened: #54

Chose to remove the endpoint rather than complete it. The implementation was too incomplete to fix minimally — it iterated over a filename string character-by-character, had pass with TODO blocks, and no running stats logic. Completing it would require CSV parsing design decisions and full BattingCardRatings/BattingCard creation logic that aren't well-specified.

Also removed the dead commented-out csv_file_to_dataframe helper block. BattingFiles model retained since live_update_pitching still references it.

PR #54 opened: https://git.manticorum.com/cal/paper-dynasty-database/pulls/54 Chose to **remove** the endpoint rather than complete it. The implementation was too incomplete to fix minimally — it iterated over a filename string character-by-character, had `pass` with TODO blocks, and no running stats logic. Completing it would require CSV parsing design decisions and full BattingCardRatings/BattingCard creation logic that aren't well-specified. Also removed the dead commented-out `csv_file_to_dataframe` helper block. `BattingFiles` model retained since `live_update_pitching` still references it.
cal added the
ai-pr-opened
 label 2026-03-04 04:33:00 +00:00
cal closed this issue 2026-03-10 18:26:23 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ai-changes-requested

   
ai-failed

   
ai-merged

PR merged by AI ops agent

  
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-reviewing

   
ai-working

   
bug

   
enhancement

   
evolution

Card Evolution system

  
performance

   
phase-0

Render Pipeline Optimization

  
phase-1a

Schema & Data Foundation

  
phase-1b

API & Formula Engine

  
phase-1c

Bot Integration

  
phase-1d

Deployment

  
security

   
tech-debt

   
todo
No Label
ai-changes-requested
ai-failed
ai-merged
ai-pr-opened
ai-reviewed
ai-reviewing
ai-reviewing
ai-working
bug
enhancement
evolution
performance
phase-0
phase-1a
phase-1b
phase-1c
phase-1d
security
tech-debt
todo
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-database#10
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?