3 Commits

Author	SHA1	Message	Date
Cal Corum	b8c55b5723	fix: address PR #104 review feedback ... - Correct idempotency guard docstring in update_season_stats() to accurately describe the last_game FK check limitation: only detects replay of the most-recently-processed game; out-of-order re-delivery (game G after G+1) bypasses the guard. References issue #105 for the planned ProcessedGame ledger fix. - Fix migration card_type comment: 'batting' or 'pitching' → 'batter', 'sp', or 'rp' to match actual seeded values. - Remove local rarity fixture in test_season_stats_update.py that shadowed the conftest.py fixture; remove unused rarity parameter from player_batter and player_pitcher fixtures. - Update test_double_count_prevention docstring to note the known out-of-order re-delivery limitation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-03-18 00:04:04 -05:00
Cal Corum	f7bc248a9f	fix: address PR review findings ... - CRITICAL: Fix migration FK refs player(id) → player(player_id) - Remove dead is_start flag from pitching groups (no starts column) - Fix hr → homerun in test make_play helper - Add explanatory comment to ruff.toml - Replace print() with logging in seed script Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-03-17 21:38:12 -05:00
Cal Corum	da9eaa1692	test: add Phase 1a test suite (25 tests) ... - test_evolution_models: 12 tests for EvolutionTrack, EvolutionCardState, EvolutionTierBoost, EvolutionCosmetic, and PlayerSeasonStats models - test_evolution_seed: 7 tests for seed idempotency, thresholds, formulas - test_season_stats_update: 6 tests for batting/pitching aggregation, Decision integration, double-count prevention, multi-game accumulation Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-03-17 19:33:49 -05:00