From f4a90da6294b73d82fdb4f7dc900e9c5fc5c0ca6 Mon Sep 17 00:00:00 2001 From: Cal Corum Date: Mon, 6 Apr 2026 17:31:17 -0500 Subject: [PATCH] =?UTF-8?q?fix:=20review=20feedback=20=E2=80=94=20pin=20bo?= =?UTF-8?q?to3,=20use=20player=5Fid=20consistently,=20add=20comment?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Pin boto3==1.42.65 to match project convention of exact version pins - Use player_id (not player) for FK column access in card_storage.py to match the pattern used throughout the codebase - Add comment explaining the tier is None guard in S3 upload scheduling Co-Authored-By: Claude Opus 4.6 (1M context) --- app/routers_v2/players.py | 4 +++- app/services/card_storage.py | 4 ++-- requirements.txt | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/routers_v2/players.py b/app/routers_v2/players.py index dbb2ea4..744bad6 100644 --- a/app/routers_v2/players.py +++ b/app/routers_v2/players.py @@ -915,7 +915,9 @@ async def get_batter_card( # save_as=f'{player_id}-{d}-v{variant}.png' # ) - # Schedule S3 upload for variant cards that don't have an image_url yet + # Schedule S3 upload for variant cards that don't have an image_url yet. + # Skip when tier is overridden (?tier= dev preview) — those renders don't + # correspond to real variant card rows. if variant > 0 and tier is None: CardModel = BattingCard if card_type == "batting" else PitchingCard try: diff --git a/app/services/card_storage.py b/app/services/card_storage.py index 38def67..7ad4513 100644 --- a/app/services/card_storage.py +++ b/app/services/card_storage.py @@ -174,11 +174,11 @@ def backfill_variant_image_url( # 4. Locate the card row and update image_url if card_type == "batting": card = BattingCard.get( - BattingCard.player == player_id, BattingCard.variant == variant + BattingCard.player_id == player_id, BattingCard.variant == variant ) else: card = PitchingCard.get( - PitchingCard.player == player_id, PitchingCard.variant == variant + PitchingCard.player_id == player_id, PitchingCard.variant == variant ) card.image_url = image_url diff --git a/requirements.txt b/requirements.txt index 7d2cd9d..c27075d 100644 --- a/requirements.txt +++ b/requirements.txt @@ -12,4 +12,4 @@ requests==2.32.3 html2image==2.0.6 jinja2==3.1.4 playwright==1.45.1 -boto3>=1.34.0 +boto3==1.42.65