fix: centralize logging config in main.py — remove basicConfig from 32 files (#26)

Moved logging.basicConfig() to app/main.py as the single source of truth.
Removed duplicate (no-op) calls from app/db_engine.py, app/dependencies.py,
and all 30 router files in app/routers_v2/. Removed the now-unused LOG_DATA
dict and date/log_level locals from dependencies.py and db_engine.py.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

app/db_engine.py

@@ -36,14 +36,6 @@ else:
         pragmas={"journal_mode": "wal", "cache_size": -1 * 64000, "synchronous": 0},
     )
 
-date = f"{datetime.now().year}-{datetime.now().month}-{datetime.now().day}"
-log_level = logging.INFO if os.environ.get("LOG_LEVEL") == "INFO" else "WARN"
-logging.basicConfig(
-    filename=f"logs/database/{date}.log",
-    format="%(asctime)s - database - %(levelname)s - %(message)s",
-    level=log_level,
-)
-
 # 2025, 2005
 ranked_cardsets = [24, 25, 26, 27, 28, 29]
 LIVE_CARDSET_ID = 27
@@ -925,7 +917,13 @@ CardPosition.add_index(pos_index)
 
 if not SKIP_TABLE_CREATION:
     db.create_tables(
-        [BattingCard, BattingCardRatings, PitchingCard, PitchingCardRatings, CardPosition],
+        [
+            BattingCard,
+            BattingCardRatings,
+            PitchingCard,
+            PitchingCardRatings,
+            CardPosition,
+        ],
         safe=True,
     )
 

app/dependencies.py

@@ -5,21 +5,6 @@ import os
 import requests
 from fastapi.security import OAuth2PasswordBearer
 
-date = f"{datetime.datetime.now().year}-{datetime.datetime.now().month}-{datetime.datetime.now().day}"
-LOG_DATA = {
-    "filename": f"logs/database/{date}.log",
-    "format": "%(asctime)s - database - %(levelname)s - %(message)s",
-    "log_level": logging.INFO if os.environ.get("LOG_LEVEL") == "INFO" else "WARN",
-}
-
-
-logging.basicConfig(
-    filename=LOG_DATA["filename"],
-    format=LOG_DATA["format"],
-    level=LOG_DATA["log_level"],
-)
-
-
 oauth2_scheme = OAuth2PasswordBearer(tokenUrl="token")
 master_debug = False
 DB_URL = "https://pd.manticorum.com/api/"

app/main.py

@@ -1,7 +1,18 @@
+import logging
+import os
+from datetime import datetime
+
 from fastapi import FastAPI, Request
 from fastapi.openapi.docs import get_swagger_ui_html
 from fastapi.openapi.utils import get_openapi
 
+_log_date = f"{datetime.now().year}-{datetime.now().month}-{datetime.now().day}"
+logging.basicConfig(
+    filename=f"logs/database/{_log_date}.log",
+    format="%(asctime)s - database - %(levelname)s - %(message)s",
+    level=logging.INFO if os.environ.get("LOG_LEVEL") == "INFO" else logging.WARNING,
+)
+
 # from fastapi.staticfiles import StaticFiles
 # from fastapi.templating import Jinja2Templates
 

app/routers_v2/admin.py

@@ -2,13 +2,8 @@ from fastapi import APIRouter, Depends, HTTPException
 import logging
 
 from ..db_engine import Player
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA, PRIVATE_IN_SCHEMA
+from ..dependencies import oauth2_scheme, valid_token, PRIVATE_IN_SCHEMA
 
-logging.basicConfig(
-    filename=LOG_DATA['filename'],
-    format=LOG_DATA['format'],
-    level=LOG_DATA['log_level']
-)
 
 router = APIRouter(
     prefix='/api/v2/admin',

app/routers_v2/awards.py

@@ -5,13 +5,8 @@ import pydantic
 from pandas import DataFrame
 
 from ..db_engine import Award, model_to_dict
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA, PRIVATE_IN_SCHEMA
+from ..dependencies import oauth2_scheme, valid_token, PRIVATE_IN_SCHEMA
 
-logging.basicConfig(
-    filename=LOG_DATA['filename'],
-    format=LOG_DATA['format'],
-    level=LOG_DATA['log_level']
-)
 
 router = APIRouter(
     prefix='/api/v2/awards',

app/routers_v2/batstats.py

@@ -7,13 +7,8 @@ import pydantic
 from pandas import DataFrame
 
 from ..db_engine import db, BattingStat, model_to_dict, fn, Card, Player, Current
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA, PRIVATE_IN_SCHEMA
+from ..dependencies import oauth2_scheme, valid_token, PRIVATE_IN_SCHEMA
 
-logging.basicConfig(
-    filename=LOG_DATA['filename'],
-    format=LOG_DATA['format'],
-    level=LOG_DATA['log_level']
-)
 
 router = APIRouter(
     prefix='/api/v2/batstats',

app/routers_v2/battingcardratings.py

@@ -18,13 +18,8 @@ from ..db_engine import (
     CardPosition,
 )
 from ..db_helpers import upsert_batting_card_ratings
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA, PRIVATE_IN_SCHEMA
+from ..dependencies import oauth2_scheme, valid_token, PRIVATE_IN_SCHEMA
 
-logging.basicConfig(
-    filename=LOG_DATA["filename"],
-    format=LOG_DATA["format"],
-    level=LOG_DATA["log_level"],
-)
 
 router = APIRouter(prefix="/api/v2/battingcardratings", tags=["battingcardratings"])
 RATINGS_FILE = "storage/batting-ratings.csv"

app/routers_v2/battingcards.py

@@ -7,13 +7,8 @@ import pydantic
 
 from ..db_engine import db, BattingCard, model_to_dict, fn, Player, MlbPlayer
 from ..db_helpers import upsert_batting_cards
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA["filename"],
-    format=LOG_DATA["format"],
-    level=LOG_DATA["log_level"],
-)
 
 router = APIRouter(prefix="/api/v2/battingcards", tags=["battingcards"])
 

app/routers_v2/cardpositions.py

@@ -6,13 +6,8 @@ from pydantic import root_validator
 
 from ..db_engine import db, CardPosition, model_to_dict, Player, fn
 from ..db_helpers import upsert_card_positions
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA["filename"],
-    format=LOG_DATA["format"],
-    level=LOG_DATA["log_level"],
-)
 
 router = APIRouter(prefix="/api/v2/cardpositions", tags=["cardpositions"])
 

app/routers_v2/cards.py

@@ -5,13 +5,8 @@ import pydantic
 from pandas import DataFrame
 
 from ..db_engine import db, Card, model_to_dict, Team, Player, Pack, Paperdex, CARDSETS
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA['filename'],
-    format=LOG_DATA['format'],
-    level=LOG_DATA['log_level']
-)
 
 router = APIRouter(
     prefix='/api/v2/cards',

app/routers_v2/cardsets.py

@@ -5,13 +5,8 @@ import pydantic
 from pandas import DataFrame
 
 from ..db_engine import Cardset, model_to_dict, fn, Event
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA['filename'],
-    format=LOG_DATA['format'],
-    level=LOG_DATA['log_level']
-)
 
 router = APIRouter(
     prefix='/api/v2/cardsets',

app/routers_v2/current.py

@@ -5,13 +5,8 @@ import logging
 import pydantic
 
 from ..db_engine import Current, model_to_dict
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA, PRIVATE_IN_SCHEMA
+from ..dependencies import oauth2_scheme, valid_token, PRIVATE_IN_SCHEMA
 
-logging.basicConfig(
-    filename=LOG_DATA['filename'],
-    format=LOG_DATA['format'],
-    level=LOG_DATA['log_level']
-)
 
 router = APIRouter(
     prefix='/api/v2/current',

app/routers_v2/decisions.py

@@ -16,13 +16,8 @@ from ..db_engine import (
     StratPlay,
 )
 from ..db_helpers import upsert_decisions
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA["filename"],
-    format=LOG_DATA["format"],
-    level=LOG_DATA["log_level"],
-)
 
 router = APIRouter(prefix="/api/v2/decisions", tags=["decisions"])
 

app/routers_v2/events.py

@@ -5,13 +5,8 @@ import pydantic
 from pandas import DataFrame
 
 from ..db_engine import Event, model_to_dict, fn
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA['filename'],
-    format=LOG_DATA['format'],
-    level=LOG_DATA['log_level']
-)
 
 router = APIRouter(
     prefix='/api/v2/events',

app/routers_v2/gamerewards.py

@@ -5,13 +5,8 @@ import pydantic
 from pandas import DataFrame
 
 from ..db_engine import GameRewards, model_to_dict
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA['filename'],
-    format=LOG_DATA['format'],
-    level=LOG_DATA['log_level']
-)
 
 router = APIRouter(
     prefix='/api/v2/gamerewards',

app/routers_v2/gauntletrewards.py

@@ -5,13 +5,8 @@ import pydantic
 
 from ..db_engine import db, GauntletReward, model_to_dict, DatabaseError
 from ..db_helpers import upsert_gauntlet_rewards
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA["filename"],
-    format=LOG_DATA["format"],
-    level=LOG_DATA["log_level"],
-)
 
 router = APIRouter(prefix="/api/v2/gauntletrewards", tags=["gauntletrewards"])
 

app/routers_v2/gauntletruns.py

@@ -5,13 +5,8 @@ import logging
 import pydantic
 
 from ..db_engine import GauntletRun, model_to_dict, DatabaseError
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA['filename'],
-    format=LOG_DATA['format'],
-    level=LOG_DATA['log_level']
-)
 
 router = APIRouter(
     prefix='/api/v2/gauntletruns',

app/routers_v2/mlbplayers.py

@@ -16,13 +16,8 @@ from ..db_engine import (
     query_to_csv,
 )
 from ..db_helpers import upsert_mlb_players
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA["filename"],
-    format=LOG_DATA["format"],
-    level=LOG_DATA["log_level"],
-)
 
 router = APIRouter(prefix="/api/v2/mlbplayers", tags=["mlbplayers"])
 

app/routers_v2/notifications.py

@@ -6,13 +6,8 @@ import pydantic
 from pandas import DataFrame
 
 from ..db_engine import Notification, model_to_dict, fn
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA['filename'],
-    format=LOG_DATA['format'],
-    level=LOG_DATA['log_level']
-)
 
 router = APIRouter(
     prefix='/api/v2/notifs',

app/routers_v2/packs.py

@@ -7,13 +7,8 @@ import pydantic
 from pandas import DataFrame
 
 from ..db_engine import db, Cardset, model_to_dict, Pack, Team, PackType
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA['filename'],
-    format=LOG_DATA['format'],
-    level=LOG_DATA['log_level']
-)
 
 router = APIRouter(
     prefix='/api/v2/packs',

app/routers_v2/packtypes.py

@@ -5,13 +5,8 @@ import pydantic
 from pandas import DataFrame
 
 from ..db_engine import PackType, model_to_dict, fn
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA['filename'],
-    format=LOG_DATA['format'],
-    level=LOG_DATA['log_level']
-)
 
 router = APIRouter(
     prefix='/api/v2/packtypes',

app/routers_v2/paperdex.py

@@ -6,13 +6,8 @@ import pydantic
 from pandas import DataFrame
 
 from ..db_engine import Paperdex, model_to_dict, Player, Cardset, Team
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA['filename'],
-    format=LOG_DATA['format'],
-    level=LOG_DATA['log_level']
-)
 
 router = APIRouter(
     prefix='/api/v2/paperdex',

app/routers_v2/pitchingcardratings.py

@@ -19,13 +19,8 @@ from ..db_engine import (
     CardPosition,
 )
 from ..db_helpers import upsert_pitching_card_ratings
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA["filename"],
-    format=LOG_DATA["format"],
-    level=LOG_DATA["log_level"],
-)
 
 router = APIRouter(prefix="/api/v2/pitchingcardratings", tags=["pitchingcardratings"])
 RATINGS_FILE = "storage/pitching-ratings.csv"

app/routers_v2/pitchingcards.py

@@ -7,13 +7,8 @@ import pydantic
 
 from ..db_engine import db, PitchingCard, model_to_dict, Player, fn, MlbPlayer
 from ..db_helpers import upsert_pitching_cards
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA["filename"],
-    format=LOG_DATA["format"],
-    level=LOG_DATA["log_level"],
-)
 
 router = APIRouter(prefix="/api/v2/pitchingcards", tags=["pitchingcards"])
 

app/routers_v2/pitstats.py

@@ -6,13 +6,8 @@ import pydantic
 from pandas import DataFrame
 
 from ..db_engine import db, PitchingStat, model_to_dict, Card, Player, Current
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA['filename'],
-    format=LOG_DATA['format'],
-    level=LOG_DATA['log_level']
-)
 
 router = APIRouter(
     prefix='/api/v2/pitstats',

app/routers_v2/players.py

@@ -28,7 +28,7 @@ from ..db_engine import (
     MlbPlayer,
 )
 from ..db_helpers import upsert_players
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
 # Franchise normalization: Convert city+team names to city-agnostic team names
 # This enables cross-era player matching (e.g., 'Oakland Athletics' -> 'Athletics')
@@ -73,11 +73,6 @@ def normalize_franchise(franchise: str) -> str:
     return FRANCHISE_NORMALIZE.get(titled, titled)
 
 
-logging.basicConfig(
-    filename=LOG_DATA["filename"],
-    format=LOG_DATA["format"],
-    level=LOG_DATA["log_level"],
-)
 
 router = APIRouter(prefix="/api/v2/players", tags=["players"])
 

app/routers_v2/rarity.py

@@ -5,13 +5,8 @@ import pydantic
 from pandas import DataFrame
 
 from ..db_engine import Rarity, model_to_dict, fn
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA['filename'],
-    format=LOG_DATA['format'],
-    level=LOG_DATA['log_level']
-)
 
 router = APIRouter(
     prefix='/api/v2/rarities',

app/routers_v2/results.py

@@ -5,13 +5,8 @@ import pydantic
 from pandas import DataFrame
 
 from ..db_engine import Result, model_to_dict, Team, DataError
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA['filename'],
-    format=LOG_DATA['format'],
-    level=LOG_DATA['log_level']
-)
 
 router = APIRouter(
     prefix='/api/v2/results',

app/routers_v2/rewards.py

@@ -6,13 +6,8 @@ import pydantic
 from pandas import DataFrame
 
 from ..db_engine import Reward, model_to_dict, fn
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA['filename'],
-    format=LOG_DATA['format'],
-    level=LOG_DATA['log_level']
-)
 
 router = APIRouter(
     prefix='/api/v2/rewards',

app/routers_v2/scouting.py

@@ -3,14 +3,9 @@ import logging
 import pydantic
 
 from ..db_engine import Player
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 from ..player_scouting import get_player_ids
 
-logging.basicConfig(
-    filename=LOG_DATA['filename'],
-    format=LOG_DATA['format'],
-    level=LOG_DATA['log_level']
-)
 
 router = APIRouter(
     prefix='/api/v2/scouting',

app/routers_v2/stratgame.py

@@ -5,13 +5,8 @@ import pandas as pd
 import pydantic
 
 from ..db_engine import StratGame, model_to_dict, fn
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA['filename'],
-    format=LOG_DATA['format'],
-    level=LOG_DATA['log_level']
-)
 
 router = APIRouter(
     prefix='/api/v2/games',

app/routers_v2/stratplays.py

@@ -19,13 +19,8 @@ from ..db_engine import (
     Decision,
 )
 from ..db_helpers import upsert_strat_plays
-from ..dependencies import oauth2_scheme, valid_token, LOG_DATA
+from ..dependencies import oauth2_scheme, valid_token
 
-logging.basicConfig(
-    filename=LOG_DATA["filename"],
-    format=LOG_DATA["format"],
-    level=LOG_DATA["log_level"],
-)
 
 router = APIRouter(prefix="/api/v2/plays", tags=["plays"])
 

app/routers_v2/teams.py

@@ -35,15 +35,9 @@ from ..db_engine import (
 from ..dependencies import (
     oauth2_scheme,
     valid_token,
-    LOG_DATA,
     PRIVATE_IN_SCHEMA,
 )
 
-logging.basicConfig(
-    filename=LOG_DATA["filename"],
-    format=LOG_DATA["format"],
-    level=LOG_DATA["log_level"],
-)
 
 router = APIRouter(prefix="/api/v2/teams", tags=["teams"])