From f1d289a0e966aa3073fe643052691dd5a92139d2 Mon Sep 17 00:00:00 2001 From: Cal Corum Date: Tue, 3 Mar 2026 21:02:47 -0600 Subject: [PATCH] fix: consolidate redundant double-query in get_one_play (#14) Reuse the result of get_or_none instead of discarding it and calling get_by_id again, eliminating one unnecessary round-trip per request. Co-Authored-By: Claude Sonnet 4.6 --- app/routers_v2/stratplays.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/routers_v2/stratplays.py b/app/routers_v2/stratplays.py index b4bd7cc..2fc8150 100644 --- a/app/routers_v2/stratplays.py +++ b/app/routers_v2/stratplays.py @@ -1390,10 +1390,10 @@ async def get_game_summary( @router.get("/{play_id}") async def get_one_play(play_id: int): - if StratPlay.get_or_none(StratPlay.id == play_id) is None: + play = StratPlay.get_or_none(StratPlay.id == play_id) + if play is None: raise HTTPException(status_code=404, detail=f"Play ID {play_id} not found") - r_play = model_to_dict(StratPlay.get_by_id(play_id)) - return r_play + return model_to_dict(play) @router.patch("/{play_id}")