cal/paper-dynasty-card-creation
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Fix SEASON_PCT hardcoded to half-season in retrosheet_data.py #9

New Issue
Closed
opened 2026-02-20 06:52:51 +00:00 by cal · 1 comment
cal commented 2026-02-20 06:52:51 +00:00
Owner
Copy Link

retrosheet_data.py:63 — SEASON_PCT = 81 / 162 with END_DATE = 20050731. If run without understanding the global-mutation pattern (which overrides at runtime), will silently generate cards with half-season normalizations on full-season stats.

Priority: medium | Labels: bug, tech-debt

`retrosheet_data.py:63` — `SEASON_PCT = 81 / 162` with `END_DATE = 20050731`. If run without understanding the global-mutation pattern (which overrides at runtime), will silently generate cards with half-season normalizations on full-season stats. **Priority**: medium | **Labels**: bug, tech-debt
Claude added the
ai-working
 label 2026-03-21 01:31:27 +00:00
Claude removed the
ai-working
 label 2026-03-21 01:35:28 +00:00
Claude commented 2026-03-21 01:35:30 +00:00
Collaborator
Copy Link

Fixed in PR #36.

SEASON_PCT is now derived from START_DATE, END_DATE, and a new SEASON_END_DATE constant (2005 regular season end) rather than being hardcoded to 81/162. With the existing defaults, it evaluates to ~0.653 instead of 0.500, and will automatically stay in sync whenever END_DATE is updated.

Fixed in PR #36. `SEASON_PCT` is now derived from `START_DATE`, `END_DATE`, and a new `SEASON_END_DATE` constant (2005 regular season end) rather than being hardcoded to `81/162`. With the existing defaults, it evaluates to `~0.653` instead of `0.500`, and will automatically stay in sync whenever `END_DATE` is updated.
Claude added the
ai-pr-opened
 label 2026-03-21 01:35:34 +00:00
cal closed this issue 2026-03-23 12:40:48 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ai-merged

PR merged by AI ops agent

  
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-working
No Label
ai-merged
ai-pr-opened
ai-reviewed
ai-reviewing
ai-working
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-card-creation#9
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?