Fix running() assigning xb_pct = 20 on parse error #8

New Issue

cal · 2026-02-20T06:52:45Z

cal commented

2026-02-20 06:52:45 +00:00

batters/calcs_batter.py:485-487 — On parse failure, xb_pct = 20 (raw integer, not fraction). Computes round(6 + (10 * 20)) = 206, clamped to max 17 = elite baserunning rating. Any player with unparseable XBT% silently gets maximum speed.

Priority: medium | Labels: bug

`batters/calcs_batter.py:485-487` — On parse failure, `xb_pct = 20` (raw integer, not fraction). Computes `round(6 + (10 * 20)) = 206`, clamped to max 17 = elite baserunning rating. Any player with unparseable XBT% silently gets maximum speed. **Priority**: medium | **Labels**: bug

Claude added the

ai-working

label 2026-03-21 02:31:23 +00:00

cal referenced this issue from a commit

2026-03-21 02:32:19 +00:00

fix: return default 8 on XBT% parse error in running() (#8)

Claude referenced a pull request that will close this issue

2026-03-21 02:32:25 +00:00

fix: return default 8 on XBT% parse error in running() (#8) #37

Claude removed the

ai-working

label 2026-03-21 02:32:29 +00:00

Claude commented

2026-03-21 02:32:31 +00:00

Fixed in PR #37: #37

Changed the except block in running() to return 8 instead of setting xb_pct = 20. Parse errors now produce the same conservative average rating (8) as an empty string, rather than silently awarding elite baserunning.

Fixed in PR #37: https://git.manticorum.com/cal/paper-dynasty-card-creation/pulls/37 Changed the `except` block in `running()` to `return 8` instead of setting `xb_pct = 20`. Parse errors now produce the same conservative average rating (8) as an empty string, rather than silently awarding elite baserunning.

Claude added the

ai-pr-opened

label 2026-03-21 02:32:34 +00:00

Claude closed this issue

2026-03-23 03:52:20 +00:00

Claude referenced this issue from a commit

2026-03-23 03:52:22 +00:00

Merge pull request 'fix: return default 8 on XBT% parse error in running() (#8)' (#37) from ai/paper-dynasty-card-creation#8 into main

Sign in to join this conversation.