cal/paper-dynasty-card-creation
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: reconcile refractor visual spec with mockup and playground #55

New Issue
Closed
opened 2026-04-06 22:33:53 +00:00 by cal · 1 comment
cal commented 2026-04-06 22:33:53 +00:00
Owner
Copy Link

Found during PR #54 review. Three inconsistencies between docs/refractor-visual-spec.md, docs/refractor-tier-mockup.html, and docs/card-cosmetics-playground.html:

  1. Spec text vs mockup on glow behavior: Spec says "metallic effect automatically enables glow pulse" but the mockup decoupled these. Update spec to match.
  2. Glow pulse CSS keyframe values stale: Mockup intensified diamond-glow-pulse values but spec still documents the old ones.
  3. Playground badge colors don't match updated tier palette: T2/T3/T4 badge backgrounds use old colors (gold/purple/teal) instead of the updated blue/red/purple.

All three are spec/doc consistency issues — no production code affected.

Found during PR #54 review. Three inconsistencies between `docs/refractor-visual-spec.md`, `docs/refractor-tier-mockup.html`, and `docs/card-cosmetics-playground.html`: 1. **Spec text vs mockup on glow behavior**: Spec says "metallic effect automatically enables glow pulse" but the mockup decoupled these. Update spec to match. 2. **Glow pulse CSS keyframe values stale**: Mockup intensified `diamond-glow-pulse` values but spec still documents the old ones. 3. **Playground badge colors don't match updated tier palette**: T2/T3/T4 badge backgrounds use old colors (gold/purple/teal) instead of the updated blue/red/purple. All three are spec/doc consistency issues — no production code affected.
Claude added the
ai-working
 label 2026-04-06 23:01:10 +00:00
Claude added the
ai-pr-opened
 label 2026-04-06 23:04:23 +00:00
Claude commented 2026-04-06 23:04:29 +00:00
Collaborator
Copy Link

Fixed in PR #56.

Three doc-only changes:

  1. Glow/metallic decoupling — removed "metallic automatically enables glow pulse"; replaced with explicit rule: metallic and glow are independent, glow is ON for T4 only.
  2. Stale keyframe values — updated diamond-glow-pulse 0%/50%/100% spread values to match the intensified mockup (5px→8px, 8px→14px, added 24px outer ring, explicit 100% frame).
  3. Playground badge colors — T2/T3/T4 badges updated from gold/purple/teal to blue/red/purple to match the approved tier palette.
Fixed in PR #56. Three doc-only changes: 1. **Glow/metallic decoupling** — removed "metallic automatically enables glow pulse"; replaced with explicit rule: metallic and glow are independent, glow is ON for T4 only. 2. **Stale keyframe values** — updated `diamond-glow-pulse` `0%`/`50%`/`100%` spread values to match the intensified mockup (5px→8px, 8px→14px, added 24px outer ring, explicit `100%` frame). 3. **Playground badge colors** — T2/T3/T4 badges updated from gold/purple/teal to blue/red/purple to match the approved tier palette.
Claude removed the
ai-working
 label 2026-04-06 23:04:34 +00:00
cal closed this issue 2026-04-08 00:26:30 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ai-changes-requested

   
ai-merged

PR merged by AI ops agent

  
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-working
No Label
ai-changes-requested
ai-merged
ai-pr-opened
ai-reviewed
ai-reviewing
ai-working
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-card-creation#55
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?