Remove dead LAST_WEEK_RATIO ternary — both branches are 0.0 #19

New Issue

cal · 2026-02-20T06:53:43Z

cal commented

2026-02-20 06:53:43 +00:00

retrosheet_data.py:68 — LAST_WEEK_RATIO = 0.0 if PLAYER_DESCRIPTION == 'Live' else 0.0. Both branches evaluate to 0.0. Conditional is dead code.

Priority: low | Labels: tech-debt

`retrosheet_data.py:68` — `LAST_WEEK_RATIO = 0.0 if PLAYER_DESCRIPTION == 'Live' else 0.0`. Both branches evaluate to 0.0. Conditional is dead code. **Priority**: low | **Labels**: tech-debt

Claude referenced this issue

2026-03-21 01:35:23 +00:00

fix: derive SEASON_PCT from date range instead of hardcoding half-season (#9) #36

Claude added the

ai-working

label 2026-03-21 12:01:11 +00:00

cal referenced this issue from a commit

2026-03-21 12:03:42 +00:00

fix: remove dead LAST_WEEK_RATIO ternary — both branches are 0.0 (#19)

Claude referenced a pull request that will close this issue

2026-03-21 12:03:47 +00:00

fix: remove dead LAST_WEEK_RATIO ternary — both branches are 0.0 (#19) #45

Claude removed the

ai-working

label 2026-03-21 12:03:52 +00:00

Claude commented

2026-03-21 12:03:53 +00:00

Fixed in PR #45. Replaced 0.0 if PLAYER_DESCRIPTION == "Live" else 0.0 with a direct LAST_WEEK_RATIO = 0.0 assignment — single-line, no behaviour change.

Fixed in PR #45. Replaced `0.0 if PLAYER_DESCRIPTION == "Live" else 0.0` with a direct `LAST_WEEK_RATIO = 0.0` assignment — single-line, no behaviour change.

Claude added the

ai-pr-opened

label 2026-03-21 12:04:01 +00:00

Claude closed this issue

2026-03-23 03:53:00 +00:00

Claude referenced this issue from a commit

2026-03-23 03:53:00 +00:00

Merge pull request 'fix: remove dead LAST_WEEK_RATIO ternary — both branches are 0.0 (#19)' (#45) from ai/paper-dynasty-card-creation-19 into main

Sign in to join this conversation.